You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kszucs (via GitHub)" <gi...@apache.org> on 2025/03/17 12:09:52 UTC
[PR] [C++] Make `VisitType()` fallback branch unreachable [arrow]
kszucs opened a new pull request, #45815:
URL: https://github.com/apache/arrow/pull/45815
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45816: [C++] Make `VisitType()` fallback branch unreachable [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #45815:
URL: https://github.com/apache/arrow/pull/45815#issuecomment-2729306168
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45816: [C++] Make `VisitType()` fallback branch unreachable [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #45815:
URL: https://github.com/apache/arrow/pull/45815#issuecomment-2750674782
@kszucs Do you want to rebase and then merge if CI is green?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45816: [C++] Make `VisitType()` fallback branch unreachable [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #45815:
URL: https://github.com/apache/arrow/pull/45815#issuecomment-2751808948
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit b9cb52f67bbcaf5cc60c10b45ca2f68e955e0600.
None of the specified runs were found on the Conbench server.
The [full Conbench report](https://github.com/apache/arrow/runs/39384183141) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45816: [C++] Make `VisitType()` fallback branch unreachable [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45815:
URL: https://github.com/apache/arrow/pull/45815#issuecomment-2729275323
:warning: GitHub issue #45816 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45816: [C++] Make `VisitType()` fallback branch unreachable [arrow]
Posted by "kszucs (via GitHub)" <gi...@apache.org>.
kszucs commented on PR #45815:
URL: https://github.com/apache/arrow/pull/45815#issuecomment-2729382776
Shall we explicitly test the following use case?
```cpp
auto handle_type = [&](auto&& type) {
using Type = std::decay_t<decltype(type)>;
if constexpr (::arrow::is_boolean(Type::type_id)) {
...
}
else if constexpr (::arrow::is_primitive(Type::type_id)) {
...
}
/* else etc. */
};
return VisitType(*values.type(), handle_type);
```
If yes, then where? Perhaps modify an existing use case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45816: [C++] Make `VisitType()` fallback branch unreachable [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #45815:
URL: https://github.com/apache/arrow/pull/45815#issuecomment-2729305641
I think this is a good idea, let's see if it breaks CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45816: [C++] Make `VisitType()` fallback branch unreachable [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45815:
URL: https://github.com/apache/arrow/pull/45815#issuecomment-2729315186
Revision: 06771968819d80e2ba11eba28e063aa14cae7141
Submitted crossbow builds: [ursacomputing/crossbow @ actions-7723444ace](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7723444ace)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/13899444378/job/38887464254)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/13899444035/job/38887463001)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/13899445092/job/38887466505)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/13899443827/job/38887461631)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/13899444102/job/38887463849)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/13899444128/job/38887463840)|
|test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/13899444681/job/38887465719)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/13899444062/job/38887463049)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/13899443864/job/38887461628)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/13899443887/job/38887461620)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/13899444677/job/38887465909)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/13899444251/job/38887463934)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/13899443818/job/38887462196)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/13899443846/job/38887462172)|
|test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/13899444739/job/38887465853)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/13899444331/job/38887464170)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/13899444606/job/38887465490)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/13899444029/job/38887463077)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/13899443947/job/38887461772)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/13899444187/job/38887463965)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/13899444454/job/38887464272)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/13899444456/job/38887464441)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/13899444514/job/38887465190)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45816: [C++] Make `VisitType()` fallback branch unreachable [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #45815:
URL: https://github.com/apache/arrow/pull/45815#issuecomment-2729449642
IMHO we don't have to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [C++] Make `VisitType()` fallback branch unreachable [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45815:
URL: https://github.com/apache/arrow/pull/45815#issuecomment-2729255223
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45816: [C++] Make `VisitType()` fallback branch unreachable [arrow]
Posted by "kszucs (via GitHub)" <gi...@apache.org>.
kszucs merged PR #45815:
URL: https://github.com/apache/arrow/pull/45815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org