You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by lh...@apache.org on 2026/04/22 11:27:00 UTC
(pulsar) branch master updated: [fix][test] Fix flaky OffloadPrefixTest.testPositionOnEdgeOfLedger race with ledger rollover (#25561)
This is an automated email from the ASF dual-hosted git repository.
lhotari pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 77999fc8a94 [fix][test] Fix flaky OffloadPrefixTest.testPositionOnEdgeOfLedger race with ledger rollover (#25561)
77999fc8a94 is described below
commit 77999fc8a9464b5af7ba0e541d3beb5906f83714
Author: Matteo Merli <mm...@apache.org>
AuthorDate: Wed Apr 22 04:26:54 2026 -0700
[fix][test] Fix flaky OffloadPrefixTest.testPositionOnEdgeOfLedger race with ledger rollover (#25561)
---
.../java/org/apache/bookkeeper/mledger/impl/OffloadPrefixTest.java | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/OffloadPrefixTest.java b/managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/OffloadPrefixTest.java
index e301d082b8f..e991ceabf45 100644
--- a/managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/OffloadPrefixTest.java
+++ b/managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/OffloadPrefixTest.java
@@ -57,6 +57,7 @@ import org.apache.commons.lang3.tuple.Pair;
import org.apache.pulsar.common.policies.data.OffloadPoliciesImpl;
import org.apache.pulsar.metadata.api.MetadataStoreException;
import org.apache.pulsar.metadata.impl.FaultInjectionMetadataStore;
+import org.awaitility.Awaitility;
import org.testng.Assert;
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;
@@ -233,7 +234,11 @@ public class OffloadPrefixTest extends MockedBookKeeperTestCase {
String content = "entry-" + i;
ledger.addEntry(content.getBytes());
}
- assertEquals(ledger.getLedgersInfoAsList().size(), 2);
+ // After filling exactly 2 ledgers, the 2nd is closed and a 3rd empty ledger starts
+ // being created asynchronously. Wait for that to finish so the rest of the test runs
+ // against a stable state (l1 full, l2 full, l3 empty) instead of racing with rollover.
+ Awaitility.await().untilAsserted(() ->
+ assertEquals(ledger.getLedgersInfoAsList().size(), 3));
Position p = ledger.getLastConfirmedEntry(); // position at end of second ledger