[GitHub] [pinot] Jackie-Jiang commented on pull request #10352: Encapsulate changes in IndexLoadingConfig and SegmentGeneratorConfig

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on PR #10352:
URL: https://github.com/apache/pinot/pull/10352#issuecomment-1449002253

   Trying to understand why making the `IndexLoadingConfig` fields immutable can help here. The fields within `IndexLoadingConfig` is already a copy of the original config, so it should be okay to modify them.
   Ideally we want to make `IndexLoadingConfig` directly read config from `TableConfig` and `Schema`. #10355 Shows the idea of that, but there are some tests need to be modified.
   The test failure should be caused by `HLRealtimeSegmentDataManager` line 146


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org