You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/09/04 20:40:32 UTC

Re: [PR] fix(dataset): derive virtual dataset schema from SQL Lab query [superset]

rusackas commented on PR #43313:
URL: https://github.com/apache/superset/pull/43313#issuecomment-5546203358

   This is a nice, careful fix, the fallback conditions and test matrix are thorough. I'd approve it, but wondering if we need `RCA.md` checked into the repo root though? Feels like investigation notes that belong in the PR description rather than a permanent file in the tree.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org