[GitHub] [tvm] areusch commented on a change in pull request #7707: [CI] Improve docker/build.sh to accept a docker tag parameter.

[GitBox <gi...@apache.org>]

areusch commented on a change in pull request #7707:
URL: https://github.com/apache/tvm/pull/7707#discussion_r597816150



##########
File path: docker/build.sh
##########
@@ -114,9 +124,10 @@ function upsearch () {
 # reasonable defaults if you run it outside of Jenkins.
 WORKSPACE="${WORKSPACE:-${SCRIPT_DIR}/../}"
 BUILD_TAG="${BUILD_TAG:-tvm}"
+DOCKER_IMAGE_TAG="${DOCKER_IMAGE_TAG:-latest}"
 
 # Determine the docker image name
-DOCKER_IMG_NAME="${BUILD_TAG}.${CONTAINER_TYPE}"
+DOCKER_IMG_NAME="${BUILD_TAG}.${CONTAINER_TYPE}:${DOCKER_IMAGE_TAG}"

Review comment:
       maybe want to do this after sanitizing the DOCKER_IMG_NAME below? or maybe more ideally assemble DOCKER_IMG_SPEC and use that in place of DOCKER_IMG_NAME on the command-line below

##########
File path: docker/build.sh
##########
@@ -45,6 +49,12 @@ shift 1
 DOCKERFILE_PATH="${SCRIPT_DIR}/Dockerfile.${CONTAINER_TYPE}"
 DOCKER_CONTEXT_PATH="${SCRIPT_DIR}"
 
+if [[ "$1" == "--dockertag" ]]; then

Review comment:
       not sure the "docker" prefix is necessary, since this script is already `docker/build.sh`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org