You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/04/13 00:21:31 UTC

[GitHub] [cloudstack] dhslove opened a new pull request #4916: Localization: Korean language support for all features of the new CloudStack UI.

dhslove opened a new pull request #4916:
URL: https://github.com/apache/cloudstack/pull/4916


   ### Description
   
   This PR includes fixes to complete the Korean language support of the new CloudStack UI.
   
   CloudStack explains that it supports Korean, but only some features are translated. Compared to the en-us.json file, it is not up to date on new features.
   
   To support Korean language support for new features and more modern Korean language support, the contents of en-us.json were copied to the ko-kr.json file and retranslated into Korean.
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [x] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   In the new CloudStack UI, you can check the Korean translation result by selecting Korean from'Language'.
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4916: Localization: Korean language support for all features of the new CloudStack UI.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4916:
URL: https://github.com/apache/cloudstack/pull/4916#issuecomment-818373994


   @rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4916: Localization: Korean language support for all features of the new CloudStack UI.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4916:
URL: https://github.com/apache/cloudstack/pull/4916#issuecomment-818700272


   UI looks pretty complete with korean lang selected:
   ![Screenshot from 2021-04-13 18-03-22](https://user-images.githubusercontent.com/95203/114552899-aef67100-9c82-11eb-94bc-074bc9f849e4.png)
   Did some translation of strings via google translation to match translations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4916: Localization: Korean language support for all features of the new CloudStack UI.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4916:
URL: https://github.com/apache/cloudstack/pull/4916#issuecomment-818373600


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4916: Localization: Korean language support for all features of the new CloudStack UI.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4916:
URL: https://github.com/apache/cloudstack/pull/4916#issuecomment-818375365


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4916 (SL-JID-96)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4916: Localization: Korean language support for all features of the new CloudStack UI.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4916:
URL: https://github.com/apache/cloudstack/pull/4916#issuecomment-818700951


   Thanks @dhslove @Dajeong-Park


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #4916: Localization: Korean language support for all features of the new CloudStack UI.

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4916:
URL: https://github.com/apache/cloudstack/pull/4916


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org