You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chris Suich <ch...@netapp.com> on 2013/11/08 21:33:16 UTC
Review Request 15362: Fixed issue with detail view fields marked as
'isPassword' not being obfuscated
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15362/
-----------------------------------------------------------
Review request for cloudstack, Brian Federle and Jessica Wang.
Repository: cloudstack-git
Description
-------
Form fields marked with 'isPassword' are created as input fields with type 'password' so that the value is obfuscated. However, detail view fields (when editing) are not obfuscated. Additionally, if a value is entered and the edit form is submitted, the password is still visible in plain text.
This patch fixes the issue by respecting the 'isPassword' attribute on detail view fields.
Diffs
-----
ui/scripts/ui/widgets/detailView.js 65f71b3
Diff: https://reviews.apache.org/r/15362/diff/
Testing
-------
Thanks,
Chris Suich
Re: Review Request 15362: Fixed issue with detail view fields marked as
'isPassword' not being obfuscated
Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15362/#review28893
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Federle
On Nov. 8, 2013, 8:33 p.m., Chris Suich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15362/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2013, 8:33 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Form fields marked with 'isPassword' are created as input fields with type 'password' so that the value is obfuscated. However, detail view fields (when editing) are not obfuscated. Additionally, if a value is entered and the edit form is submitted, the password is still visible in plain text.
>
> This patch fixes the issue by respecting the 'isPassword' attribute on detail view fields.
>
>
> Diffs
> -----
>
> ui/scripts/ui/widgets/detailView.js 65f71b3
>
> Diff: https://reviews.apache.org/r/15362/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Suich
>
>
Re: Review Request 15362: Fixed issue with detail view fields
marked as 'isPassword' not being obfuscated
Posted by "SuichII, Christopher" <Ch...@netapp.com>.
Bumping this. Can someone take a look at it, please?
-Chris
--
Chris Suich
chris.suich@netapp.com
NetApp Software Engineer
Data Center Platforms – Cloud Solutions
Citrix, Cisco & Red Hat
On Nov 8, 2013, at 3:33 PM, Chris Suich <Ch...@netapp.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15362/
> -----------------------------------------------------------
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Form fields marked with 'isPassword' are created as input fields with type 'password' so that the value is obfuscated. However, detail view fields (when editing) are not obfuscated. Additionally, if a value is entered and the edit form is submitted, the password is still visible in plain text.
>
> This patch fixes the issue by respecting the 'isPassword' attribute on detail view fields.
>
>
> Diffs
> -----
>
> ui/scripts/ui/widgets/detailView.js 65f71b3
>
> Diff: https://reviews.apache.org/r/15362/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Suich
>