You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by Thiago H de Paula Figueiredo <th...@gmail.com> on 2014/01/02 21:31:09 UTC
Re: [jira] [Commented] (TAP5-2214) Make tapestry5 java8 compatible
> Ulrich Stärk commented on TAP5-2214:
> ------------------------------------
>
> Ah, I see. Howard, is there a reason why we do not have an external
> dependency on asm but are instead copying it into our sources directly?
Howard? :) I guess it was to avoid collisions with other libraries which
may use a different version of ASM.
By the way, I'm running into some weird exceptions which seem to be caused
by ASM, so it would be nice to upgrade it as soon as possible.
>
> Uli
>
>> Make tapestry5 java8 compatible
>> -------------------------------
>>
>> Key: TAP5-2214
>> URL: https://issues.apache.org/jira/browse/TAP5-2214
>> Project: Tapestry 5
>> Issue Type: Improvement
>> Components: plastic
>> Affects Versions: 5.4
>> Reporter: Joachim Van der Auwera
>> Assignee: Howard M. Lewis Ship
>> Attachments: 0001-use-asm-5.0_BETA-for-java8.patch,
>> 0002-TAP5-2214-use-ASM-5.0_BETA-for-java8-compatibility.patch
>>
>>
>> As it stands Tapestry does not work on java8. This seems to be caused
>> by ASM. Updating the enclosed asm to 5.0_Bet seems to do the trick.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.1#6144)
--
Thiago H. de Paula Figueiredo
Tapestry, Java and Hibernate consultant and developer
http://machina.com.br
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: [jira] [Commented] (TAP5-2214) Make tapestry5 java8 compatible
Posted by Howard Lewis Ship <hl...@gmail.com>.
I repackaged ASM to avoid conflicts with other copies of ASM (such as in
Hibernate). Groovy and Clojure have done the same things, among others.
On Fri, Jan 3, 2014 at 5:46 AM, Thiago H de Paula Figueiredo <
thiagohp@gmail.com> wrote:
> On Thu, 02 Jan 2014 18:53:40 -0200, Kalle Korhonen <
> kalle.o.korhonen@gmail.com> wrote:
>
> On Thu, Jan 2, 2014 at 12:31 PM, Thiago H de Paula Figueiredo <
>> thiagohp@gmail.com> wrote:
>>
>> Ulrich Stärk commented on TAP5-2214:
>>>
>>>> ------------------------------------
>>>>
>>>> Ah, I see. Howard, is there a reason why we do not have an external
>>>> dependency on asm but are instead copying it into our sources directly?
>>>>
>>>>
>>> Howard? :) I guess it was to avoid collisions with other libraries which
>>> may use a different version of ASM.
>>>
>>>
>> Yes, collisions with other libraries using ASM was the reasoning.
>>
>>> By the way, I'm running into some weird exceptions which seem to be
>>> caused
>>> by ASM, so it would be nice to upgrade it as soon as possible.
>>>
>>
> Actually, it was a mistake by me and I had just fixed it in Git, so I
> think we can leave that to when ASM releases version 5. In the mailing
> list, the team says that'll happen just after Java 8 is released.
>
>
> --
> Thiago H. de Paula Figueiredo
> Tapestry, Java and Hibernate consultant and developer
> http://machina.com.br
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>
--
Howard M. Lewis Ship
Creator of Apache Tapestry
The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!
(971) 678-5210
http://howardlewisship.com
Re: [jira] [Commented] (TAP5-2214) Make tapestry5 java8 compatible
Posted by Thiago H de Paula Figueiredo <th...@gmail.com>.
On Thu, 02 Jan 2014 18:53:40 -0200, Kalle Korhonen
<ka...@gmail.com> wrote:
> On Thu, Jan 2, 2014 at 12:31 PM, Thiago H de Paula Figueiredo <
> thiagohp@gmail.com> wrote:
>
>> Ulrich Stärk commented on TAP5-2214:
>>> ------------------------------------
>>>
>>> Ah, I see. Howard, is there a reason why we do not have an external
>>> dependency on asm but are instead copying it into our sources directly?
>>>
>>
>> Howard? :) I guess it was to avoid collisions with other libraries which
>> may use a different version of ASM.
>>
>
> Yes, collisions with other libraries using ASM was the reasoning.
>> By the way, I'm running into some weird exceptions which seem to be
>> caused
>> by ASM, so it would be nice to upgrade it as soon as possible.
Actually, it was a mistake by me and I had just fixed it in Git, so I
think we can leave that to when ASM releases version 5. In the mailing
list, the team says that'll happen just after Java 8 is released.
--
Thiago H. de Paula Figueiredo
Tapestry, Java and Hibernate consultant and developer
http://machina.com.br
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: [jira] [Commented] (TAP5-2214) Make tapestry5 java8 compatible
Posted by Kalle Korhonen <ka...@gmail.com>.
On Thu, Jan 2, 2014 at 12:31 PM, Thiago H de Paula Figueiredo <
thiagohp@gmail.com> wrote:
> Ulrich Stärk commented on TAP5-2214:
>> ------------------------------------
>>
>> Ah, I see. Howard, is there a reason why we do not have an external
>> dependency on asm but are instead copying it into our sources directly?
>>
>
> Howard? :) I guess it was to avoid collisions with other libraries which
> may use a different version of ASM.
>
Yes, collisions with other libraries using ASM was the reasoning.
> By the way, I'm running into some weird exceptions which seem to be caused
> by ASM, so it would be nice to upgrade it as soon as possible.
>
Perhaps just apply the patch, it should be fairly safe.
Kalle
>
>
>> Uli
>>
>>
>> Make tapestry5 java8 compatible
>>> -------------------------------
>>>
>>> Key: TAP5-2214
>>> URL: https://issues.apache.org/jira/browse/TAP5-2214
>>> Project: Tapestry 5
>>> Issue Type: Improvement
>>> Components: plastic
>>> Affects Versions: 5.4
>>> Reporter: Joachim Van der Auwera
>>> Assignee: Howard M. Lewis Ship
>>> Attachments: 0001-use-asm-5.0_BETA-for-java8.patch,
>>> 0002-TAP5-2214-use-ASM-5.0_BETA-for-java8-compatibility.patch
>>>
>>>
>>> As it stands Tapestry does not work on java8. This seems to be caused by
>>> ASM. Updating the enclosed asm to 5.0_Bet seems to do the trick.
>>>
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.1#6144)
>>
>
>
> --
> Thiago H. de Paula Figueiredo
> Tapestry, Java and Hibernate consultant and developer
> http://machina.com.br
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>