You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Robbie Gemmell <ro...@gmail.com> on 2013/01/28 18:51:46 UTC
Re: svn commit: r1439431 - /qpid/trunk/qpid/cpp/src/qpid/ha/Backup.cpp
It wasnt just Windows. I had been meaning to send a mail today saying the
Ubuntu builds on Jenkins were also failing since last week ..and also that
the original commit didnt seem like a NO-JIRA.
Robbie
On 28 January 2013 14:50, <ac...@apache.org> wrote:
> Author: aconway
> Date: Mon Jan 28 14:50:07 2013
> New Revision: 1439431
>
> URL: http://svn.apache.org/viewvc?rev=1439431&view=rev
> Log:
> NO-JIRA: Fix build error in windows build
>
> Modified:
> qpid/trunk/qpid/cpp/src/qpid/ha/Backup.cpp
>
> Modified: qpid/trunk/qpid/cpp/src/qpid/ha/Backup.cpp
> URL:
> http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/ha/Backup.cpp?rev=1439431&r1=1439430&r2=1439431&view=diff
>
> ==============================================================================
> --- qpid/trunk/qpid/cpp/src/qpid/ha/Backup.cpp (original)
> +++ qpid/trunk/qpid/cpp/src/qpid/ha/Backup.cpp Mon Jan 28 14:50:07 2013
> @@ -132,6 +132,7 @@ Role* Backup::promote() {
> default:
> assert(0); // Not a valid state for the Backup role..
> }
> + return 0; // Keep compiler happy
> }
>
> Backup::~Backup() {
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
> For additional commands, e-mail: commits-help@qpid.apache.org
>
>
Re: svn commit: r1439431 - /qpid/trunk/qpid/cpp/src/qpid/ha/Backup.cpp
Posted by Robbie Gemmell <ro...@gmail.com>.
It seems like quite a big change not to have a JIRA, and the commit
references thread safety issues for example which seem like a potentially
user-facing change. Even refactorings can introduce or fix bugs and so
usually deserve a JIRA in my mind.
I would tend to have a JIRA for a core-functionality refactoring like that,
or would usually only be doing it for a related reason which presumably
already had its own JIRA so at least it could be committed against that
JIRA rather than none at all.
Robbie
On 30 January 2013 15:27, Alan Conway <ac...@redhat.com> wrote:
> On Mon, 2013-01-28 at 17:51 +0000, Robbie Gemmell wrote:
> > It wasnt just Windows. I had been meaning to send a mail today saying the
> > Ubuntu builds on Jenkins were also failing since last week ..and also
> that
> > the original commit didnt seem like a NO-JIRA.
>
> I didn't JIRA it because it was a refactor, so no externally visible
> changes to document. I can JIRA refactors in the future if that's what
> people want.
>
> >
> > Robbie
> >
> > On 28 January 2013 14:50, <ac...@apache.org> wrote:
> >
> > > Author: aconway
> > > Date: Mon Jan 28 14:50:07 2013
> > > New Revision: 1439431
> > >
> > > URL: http://svn.apache.org/viewvc?rev=1439431&view=rev
> > > Log:
> > > NO-JIRA: Fix build error in windows build
> > >
> > > Modified:
> > > qpid/trunk/qpid/cpp/src/qpid/ha/Backup.cpp
> > >
> > > Modified: qpid/trunk/qpid/cpp/src/qpid/ha/Backup.cpp
> > > URL:
> > >
> http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/ha/Backup.cpp?rev=1439431&r1=1439430&r2=1439431&view=diff
> > >
> > >
> ==============================================================================
> > > --- qpid/trunk/qpid/cpp/src/qpid/ha/Backup.cpp (original)
> > > +++ qpid/trunk/qpid/cpp/src/qpid/ha/Backup.cpp Mon Jan 28 14:50:07 2013
> > > @@ -132,6 +132,7 @@ Role* Backup::promote() {
> > > default:
> > > assert(0); // Not a valid state for the Backup
> role..
> > > }
> > > + return 0; // Keep compiler happy
> > > }
> > >
> > > Backup::~Backup() {
> > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
> > > For additional commands, e-mail: commits-help@qpid.apache.org
> > >
> > >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
> For additional commands, e-mail: dev-help@qpid.apache.org
>
>
Re: svn commit: r1439431 -
/qpid/trunk/qpid/cpp/src/qpid/ha/Backup.cpp
Posted by Alan Conway <ac...@redhat.com>.
On Mon, 2013-01-28 at 17:51 +0000, Robbie Gemmell wrote:
> It wasnt just Windows. I had been meaning to send a mail today saying the
> Ubuntu builds on Jenkins were also failing since last week ..and also that
> the original commit didnt seem like a NO-JIRA.
I didn't JIRA it because it was a refactor, so no externally visible
changes to document. I can JIRA refactors in the future if that's what
people want.
>
> Robbie
>
> On 28 January 2013 14:50, <ac...@apache.org> wrote:
>
> > Author: aconway
> > Date: Mon Jan 28 14:50:07 2013
> > New Revision: 1439431
> >
> > URL: http://svn.apache.org/viewvc?rev=1439431&view=rev
> > Log:
> > NO-JIRA: Fix build error in windows build
> >
> > Modified:
> > qpid/trunk/qpid/cpp/src/qpid/ha/Backup.cpp
> >
> > Modified: qpid/trunk/qpid/cpp/src/qpid/ha/Backup.cpp
> > URL:
> > http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/ha/Backup.cpp?rev=1439431&r1=1439430&r2=1439431&view=diff
> >
> > ==============================================================================
> > --- qpid/trunk/qpid/cpp/src/qpid/ha/Backup.cpp (original)
> > +++ qpid/trunk/qpid/cpp/src/qpid/ha/Backup.cpp Mon Jan 28 14:50:07 2013
> > @@ -132,6 +132,7 @@ Role* Backup::promote() {
> > default:
> > assert(0); // Not a valid state for the Backup role..
> > }
> > + return 0; // Keep compiler happy
> > }
> >
> > Backup::~Backup() {
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
> > For additional commands, e-mail: commits-help@qpid.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org