[GitHub] [systemds] mboehm7 commented on pull request #1622: [SYSTEMDS-3382] Federated Left Indexing with Scalar

[GitBox <gi...@apache.org>]

mboehm7 commented on PR #1622:
URL: https://github.com/apache/systemds/pull/1622#issuecomment-1146883114

   LGTM - thanks for the patch @ywcb00 as well as catching and reporting this issue.
   
   After spending way too much time on debugging this issue, I found the reason and fixed it. A simple `FederationUtils.resetFedDataID()` at the beginning of the test mitigated the described problem, which however pointed to a more severe issue. In detail, after running the two other tests, we got an output ID 13 for the federated left indexing. The scalar literal was also 13 which lead to incorrect replacements when preparing the individual instructions sent to the workers. By rearranging the order to input/output replacements, we now generally prevent such problems. Thanks. 
   		


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org