You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ajay Yadava <aj...@gmail.com> on 2015/09/15 13:44:56 UTC
Review Request 38401: FALCON-1460 Move getHiveCredentials method to
ClusterHelper
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38401/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1460
https://issues.apache.org/jira/browse/FALCON-1460
Repository: falcon-git
Description
-------
Moved one method to ClusterHelper and added some unit tests.
Diffs
-----
common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 7f96827
common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 87b0fba
common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java 5756f84
common/src/main/java/org/apache/falcon/security/SecurityUtil.java 861f80f
common/src/test/java/org/apache/falcon/entity/ClusterHelperTest.java PRE-CREATION
oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java 9a6b14c
oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java f7193a3
oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationWorkflowBuilder.java 4dc55ff
oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionWorkflowBuilder.java b56f0dd
oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 2f7787d
oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java d727ca3
Diff: https://reviews.apache.org/r/38401/diff/
Testing
-------
Added a couple of unit tests.
Thanks,
Ajay Yadava
Re: Review Request 38401: FALCON-1460 Move getHiveCredentials method
to ClusterHelper
Posted by Ajay Yadava <aj...@gmail.com>.
> On Sept. 16, 2015, 6:38 a.m., Sowmya Ramesh wrote:
> > Any reason for this refactoring? Also I don't think ClusterHelper is rigth file. Can you create a new class say HiveUtils and move it there instead?
I had mentioned the reasons for refactoring in the parent JIRA. oozie adaptor is not the right place for this functionality, I encountered this use case in lifecycle. Moved helper methods to HiveUtil class.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38401/#review99186
-----------------------------------------------------------
On Sept. 15, 2015, 11:44 a.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38401/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2015, 11:44 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1460
> https://issues.apache.org/jira/browse/FALCON-1460
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Moved one method to ClusterHelper and added some unit tests.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 7f96827
> common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 87b0fba
> common/src/main/java/org/apache/falcon/entity/HiveUtil.java PRE-CREATION
> common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java 5756f84
> common/src/main/java/org/apache/falcon/security/SecurityUtil.java 861f80f
> common/src/test/java/org/apache/falcon/entity/HiveUtilTest.java PRE-CREATION
> oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java 9a6b14c
> oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java f7193a3
> oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationWorkflowBuilder.java 4dc55ff
> oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionWorkflowBuilder.java b56f0dd
> oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 2f7787d
> oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java d727ca3
>
> Diff: https://reviews.apache.org/r/38401/diff/
>
>
> Testing
> -------
>
> Added a couple of unit tests.
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 38401: FALCON-1460 Move getHiveCredentials method
to ClusterHelper
Posted by Sowmya Ramesh <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38401/#review99186
-----------------------------------------------------------
Any reason for this refactoring? Also I don't think ClusterHelper is rigth file. Can you create a new class say HiveUtils and move it there instead?
- Sowmya Ramesh
On Sept. 15, 2015, 11:44 a.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38401/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2015, 11:44 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1460
> https://issues.apache.org/jira/browse/FALCON-1460
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Moved one method to ClusterHelper and added some unit tests.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 7f96827
> common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 87b0fba
> common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java 5756f84
> common/src/main/java/org/apache/falcon/security/SecurityUtil.java 861f80f
> common/src/test/java/org/apache/falcon/entity/ClusterHelperTest.java PRE-CREATION
> oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java 9a6b14c
> oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java f7193a3
> oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationWorkflowBuilder.java 4dc55ff
> oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionWorkflowBuilder.java b56f0dd
> oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 2f7787d
> oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java d727ca3
>
> Diff: https://reviews.apache.org/r/38401/diff/
>
>
> Testing
> -------
>
> Added a couple of unit tests.
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 38401: FALCON-1460 Move getHiveCredentials method
to ClusterHelper
Posted by Sowmya Ramesh <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38401/#review99302
-----------------------------------------------------------
Ship it!
common/src/main/java/org/apache/falcon/entity/HiveUtil.java (line 41)
<https://reviews.apache.org/r/38401/#comment156204>
Minor nit: Use StringUtils.isBlank
- Sowmya Ramesh
On Sept. 16, 2015, 12:15 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38401/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2015, 12:15 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1460
> https://issues.apache.org/jira/browse/FALCON-1460
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Moved one method to ClusterHelper and added some unit tests.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 7f96827
> common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 87b0fba
> common/src/main/java/org/apache/falcon/entity/HiveUtil.java PRE-CREATION
> common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java 5756f84
> common/src/main/java/org/apache/falcon/security/SecurityUtil.java 123a1a2
> common/src/test/java/org/apache/falcon/entity/HiveUtilTest.java PRE-CREATION
> oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java f9230da
> oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java 671ae6b
> oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationWorkflowBuilder.java 4dc55ff
> oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionWorkflowBuilder.java b56f0dd
> oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 2f7787d
> oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java d727ca3
>
> Diff: https://reviews.apache.org/r/38401/diff/
>
>
> Testing
> -------
>
> Added a couple of unit tests.
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 38401: FALCON-1460 Move getHiveCredentials method
to ClusterHelper
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38401/
-----------------------------------------------------------
(Updated Sept. 16, 2015, 12:15 p.m.)
Review request for Falcon.
Changes
-------
Rebased the patch with master.
Bugs: FALCON-1460
https://issues.apache.org/jira/browse/FALCON-1460
Repository: falcon-git
Description
-------
Moved one method to ClusterHelper and added some unit tests.
Diffs (updated)
-----
common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 7f96827
common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 87b0fba
common/src/main/java/org/apache/falcon/entity/HiveUtil.java PRE-CREATION
common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java 5756f84
common/src/main/java/org/apache/falcon/security/SecurityUtil.java 123a1a2
common/src/test/java/org/apache/falcon/entity/HiveUtilTest.java PRE-CREATION
oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java f9230da
oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java 671ae6b
oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationWorkflowBuilder.java 4dc55ff
oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionWorkflowBuilder.java b56f0dd
oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 2f7787d
oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java d727ca3
Diff: https://reviews.apache.org/r/38401/diff/
Testing
-------
Added a couple of unit tests.
Thanks,
Ajay Yadava
Re: Review Request 38401: FALCON-1460 Move getHiveCredentials method
to ClusterHelper
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38401/
-----------------------------------------------------------
(Updated Sept. 16, 2015, 7:09 a.m.)
Review request for Falcon.
Bugs: FALCON-1460
https://issues.apache.org/jira/browse/FALCON-1460
Repository: falcon-git
Description
-------
Moved one method to ClusterHelper and added some unit tests.
Diffs (updated)
-----
common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 7f96827
common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 87b0fba
common/src/main/java/org/apache/falcon/entity/HiveUtil.java PRE-CREATION
common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java 5756f84
common/src/main/java/org/apache/falcon/security/SecurityUtil.java 861f80f
common/src/test/java/org/apache/falcon/entity/HiveUtilTest.java PRE-CREATION
oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java 9a6b14c
oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java f7193a3
oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationWorkflowBuilder.java 4dc55ff
oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionWorkflowBuilder.java b56f0dd
oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 2f7787d
oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java d727ca3
Diff: https://reviews.apache.org/r/38401/diff/
Testing
-------
Added a couple of unit tests.
Thanks,
Ajay Yadava