You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "wkigenyi (via GitHub)" <gi...@apache.org> on 2025/03/22 18:08:53 UTC
[PR] FINERACT-2222 [fineract]
wkigenyi opened a new pull request, #4495:
URL: https://github.com/apache/fineract/pull/4495
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2222: Rectify calculation of disbursement charges based on percentages [fineract]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #4495: FINERACT-2222: Rectify calculation of disbursement charges based on percentages
URL: https://github.com/apache/fineract/pull/4495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2222 [fineract]
Posted by "mariiaKraievska (via GitHub)" <gi...@apache.org>.
mariiaKraievska commented on PR #4495:
URL: https://github.com/apache/fineract/pull/4495#issuecomment-2760479367
Kindly asking you to use story number in the commit message and also add description in the PR title.
Example (both should look like this - PR title and commit message):
"FINERACT-XXXX: Rectify calculation of disbursement charges that are based on percentage"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2222: Rectify calculation of disbursement charges based on percentages [fineract]
Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #4495:
URL: https://github.com/apache/fineract/pull/4495#issuecomment-2766525980
Run the gradle spotlessApply on the modules that you have changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2222: Rectify calculation of disbursement charges based on percentages [fineract]
Posted by "wkigenyi (via GitHub)" <gi...@apache.org>.
wkigenyi commented on PR #4495:
URL: https://github.com/apache/fineract/pull/4495#issuecomment-2769046806
> @wkigenyi Please change the commit message to match with the PR title! We need to make sure PR title and commit message contains the required FINERACT-XXXX story number: Example: [FINERACT-2222](https://issues.apache.org/jira/browse/FINERACT-2222): Rectify calculation of disbursement charges based on percentages
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2222: Rectify calculation of disbursement charges based on percentages [fineract]
Posted by "wkigenyi (via GitHub)" <gi...@apache.org>.
wkigenyi commented on PR #4495:
URL: https://github.com/apache/fineract/pull/4495#issuecomment-2767901366
> Run the gradle spotlessApply on the modules that you have changed
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2222: Rectify calculation of disbursement charges based on percentages [fineract]
Posted by "wkigenyi (via GitHub)" <gi...@apache.org>.
wkigenyi commented on PR #4495:
URL: https://github.com/apache/fineract/pull/4495#issuecomment-2799067860
> [Fineract-2222](https://issues.apache.org/jira/browse/FINERACT-2222) seems to be an issue on the web-app end. The charges calculations seem accurate on viewing the repayment schedule and also after submitting the application. The only issue I see is that immediately after adding a charge, the Amount is shown as the percentage and not the actual amount. Please see below that the correct charges are being generated when the percentageAmount is 3 and the principal is 200.   The correct charges are being generated as shown above.
>
> The issue faced on the frontend: 
>
> I believe there is no need to make any change in fineract and changes should be made in the web-app. Please correct me if I am wrong. @wkigenyi
You are right. I think I could have looked at totally different scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2222: Rectify calculation of disbursement charges based on percentages [fineract]
Posted by "wkigenyi (via GitHub)" <gi...@apache.org>.
wkigenyi commented on PR #4495:
URL: https://github.com/apache/fineract/pull/4495#issuecomment-2770621471
Let's start with your sentence that starts with "The only issue...". You realise we do have an issue there. That is what is being fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2222: Rectify calculation of disbursement charges based on percentages [fineract]
Posted by "wkigenyi (via GitHub)" <gi...@apache.org>.
wkigenyi commented on PR #4495:
URL: https://github.com/apache/fineract/pull/4495#issuecomment-2770644713
Try to inspect the JSON response immediately after adding the disbursement charge without using the UI. You could use Postman or the browser itself. You will see that it is the percentageAmount is what is computed. Customers normally want these figures represented correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2222: Rectify calculation of disbursement charges based on percentages [fineract]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4495:
URL: https://github.com/apache/fineract/pull/4495#issuecomment-2874638634
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2222: Rectify calculation of disbursement charges based on percentages [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #4495:
URL: https://github.com/apache/fineract/pull/4495#issuecomment-2768516044
@wkigenyi Please change the commit message to match with the PR title!
We need to make sure PR title and commit message contains the required FINERACT-XXXX story number:
Example:
FINERACT-2222: Rectify calculation of disbursement charges based on percentages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2222: Rectify calculation of disbursement charges based on percentages [fineract]
Posted by "magyari-adam (via GitHub)" <gi...@apache.org>.
magyari-adam commented on PR #4495:
URL: https://github.com/apache/fineract/pull/4495#issuecomment-2769220273
Please add a test to confirm this calculates properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2222: Rectify calculation of disbursement charges based on percentages [fineract]
Posted by "JebronLames32 (via GitHub)" <gi...@apache.org>.
JebronLames32 commented on PR #4495:
URL: https://github.com/apache/fineract/pull/4495#issuecomment-2770599189
[Fineract-2222](https://issues.apache.org/jira/browse/FINERACT-2222) seems to be an issue on the web-app end. The charges calculations seem accurate on viewing the repayment schedule and also after submitting the application. The only issue I see is that immediately after adding a charge, the Amount is shown as the percentage and not the actual amount. Please see below that the correct charges are being generated when the percentageAmount is 3 and the principal is 200.
The correct charges are being generated as shown above.
The issue faced on the frontend:
I believe there is no need to make any change in fineract and changes should be made in the web-app. Please correct me if I am wrong. @wkigenyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org