You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm-commits@maven.apache.org by ev...@apache.org on 2007/03/13 10:22:53 UTC
svn commit: r517605 -
/maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/scm/command/update/AbstractUpdateCommand.java
Author: evenisse
Date: Tue Mar 13 02:22:53 2007
New Revision: 517605
URL: http://svn.apache.org/viewvc?view=rev&rev=517605
Log:
Remove java5 code
Modified:
maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/scm/command/update/AbstractUpdateCommand.java
Modified: maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/scm/command/update/AbstractUpdateCommand.java
URL: http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/scm/command/update/AbstractUpdateCommand.java?view=diff&rev=517605&r1=517604&r2=517605
==============================================================================
--- maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/scm/command/update/AbstractUpdateCommand.java (original)
+++ maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/scm/command/update/AbstractUpdateCommand.java Tue Mar 13 02:22:53 2007
@@ -59,7 +59,7 @@
List filesList = updateScmResult.getUpdatedFiles();
- if ( System.getProperty( "maven.scm.update.skipChangelog" ).equals( true ) )
+ if ( System.getProperty( "maven.scm.update.skipChangelog" ).equals( "true" ) )
{
return updateScmResult;
}
Re: svn commit: r517605 - /maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/scm/command/update/AbstractUpdateCommand.java
Posted by Emmanuel Venisse <em...@venisse.net>.
I can refactor it to use a method parameter that will be better.
Emmanuel
Brett Porter a écrit :
> Shouldn't the use of sys props be removed from inside an API?
>
> On 13/03/2007, at 2:22 AM, evenisse@apache.org wrote:
>
>> Author: evenisse
>> Date: Tue Mar 13 02:22:53 2007
>> New Revision: 517605
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=517605
>> Log:
>> Remove java5 code
>>
>> Modified:
>>
>> maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/scm/command/update/AbstractUpdateCommand.java
>>
>>
>> Modified:
>> maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/scm/command/update/AbstractUpdateCommand.java
>>
>> URL:
>> http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/scm/command/update/AbstractUpdateCommand.java?view=diff&rev=517605&r1=517604&r2=517605
>>
>> ==============================================================================
>>
>> ---
>> maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/scm/command/update/AbstractUpdateCommand.java
>> (original)
>> +++
>> maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/scm/command/update/AbstractUpdateCommand.java
>> Tue Mar 13 02:22:53 2007
>> @@ -59,7 +59,7 @@
>>
>> List filesList = updateScmResult.getUpdatedFiles();
>>
>> - if ( System.getProperty( "maven.scm.update.skipChangelog"
>> ).equals( true ) )
>> + if ( System.getProperty( "maven.scm.update.skipChangelog"
>> ).equals( "true" ) )
>> {
>> return updateScmResult;
>> }
>>
>
>
>
>
Re: svn commit: r517605 - /maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/scm/command/update/AbstractUpdateCommand.java
Posted by Brett Porter <br...@apache.org>.
Shouldn't the use of sys props be removed from inside an API?
On 13/03/2007, at 2:22 AM, evenisse@apache.org wrote:
> Author: evenisse
> Date: Tue Mar 13 02:22:53 2007
> New Revision: 517605
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=517605
> Log:
> Remove java5 code
>
> Modified:
> maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/
> scm/command/update/AbstractUpdateCommand.java
>
> Modified: maven/scm/trunk/maven-scm-api/src/main/java/org/apache/
> maven/scm/command/update/AbstractUpdateCommand.java
> URL: http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-api/src/
> main/java/org/apache/maven/scm/command/update/
> AbstractUpdateCommand.java?view=diff&rev=517605&r1=517604&r2=517605
> ======================================================================
> ========
> --- maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/
> scm/command/update/AbstractUpdateCommand.java (original)
> +++ maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/
> scm/command/update/AbstractUpdateCommand.java Tue Mar 13 02:22:53 2007
> @@ -59,7 +59,7 @@
>
> List filesList = updateScmResult.getUpdatedFiles();
>
> - if ( System.getProperty
> ( "maven.scm.update.skipChangelog" ).equals( true ) )
> + if ( System.getProperty
> ( "maven.scm.update.skipChangelog" ).equals( "true" ) )
> {
> return updateScmResult;
> }
>