You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2016/11/10 21:21:59 UTC

[jira] [Closed] (SOLR-7327) DefaultSolrHighlighter should lazily create a FVH FieldQuery.

     [ https://issues.apache.org/jira/browse/SOLR-7327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley closed SOLR-7327.
------------------------------
    Resolution: Duplicate

Done in SOLR-6692 already

> DefaultSolrHighlighter should lazily create a FVH FieldQuery.
> -------------------------------------------------------------
>
>                 Key: SOLR-7327
>                 URL: https://issues.apache.org/jira/browse/SOLR-7327
>             Project: Solr
>          Issue Type: Improvement
>          Components: highlighter
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>
> DefaultSolrHighlighter switches between both the standard/default/classic Highlighter and the FastVectorHighlighter, depending on parameters and field options.  In doHighlighting(), it loops over the docs, then loops over the highlighted fields, then decides to use one highlighter or the other.  Outside of the doc loop it creates a FastVectorHighlighter instance (cheap) and a related FieldQuery object that may or may not be cheap.  fvh.getFieldQuery takes an IndexReader instance and it will be used for certain queries like MultiTermQuery (e.g. wildcards).  We shouldn't be doing this unless we know we'll actually need it -- it should be lazily constructed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org