You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gengliangwang <gi...@git.apache.org> on 2018/10/30 09:41:17 UTC

[GitHub] spark pull request #22890: [SPARK-25883][SQL][Minor] Override method `pretty...

GitHub user gengliangwang opened a pull request:

    https://github.com/apache/spark/pull/22890

    [SPARK-25883][SQL][Minor] Override method `prettyName` in `from_avro`/`to_avro`	

    ## What changes were proposed in this pull request?
    
    Previously in from_avro/to_avro, we override the method `simpleString` and `sql` for the string output. However, the override only affects the alias naming:
    ```
    Project [from_avro('col, 
    ...
    , (mode,PERMISSIVE)) AS from_avro(col, struct<col1:bigint,col2:double>, Map(mode -> PERMISSIVE))#11]
    ```
    It only makes the alias name quite long: `from_avro(col, struct<col1:bigint,col2:double>, Map(mode -> PERMISSIVE))`).
    
    We should follow `from_csv`/`from_json` here, to override the method prettyName only, and we will get a clean alias name
    
    ```
    ... AS from_avro(col)#11
    ```
    
    ## How was this patch tested?
    
    Manual check

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gengliangwang/spark revise_from_to_avro

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22890.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22890
    
----
commit 0393510c2e06eb78d21e6113454047dba7316c6e
Author: Gengliang Wang <ge...@...>
Date:   2018-10-30T07:08:47Z

    overriding prettyName

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22890: [SPARK-25883][SQL][Minor] Override method `prettyName` i...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22890
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22890: [SPARK-25883][SQL][Minor] Override method `prettyName` i...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22890
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4623/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22890: [SPARK-25883][SQL][Minor] Override method `prettyName` i...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22890
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98264/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22890: [SPARK-25883][SQL][Minor] Override method `prettyName` i...

Posted by gatorsmile <gi...@git.apache.org>.

Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/22890
  
    Thanks! Merged to master.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22890: [SPARK-25883][SQL][Minor] Override method `prettyName` i...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22890
  
    **[Test build #98264 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98264/testReport)** for PR 22890 at commit [`0393510`](https://github.com/apache/spark/commit/0393510c2e06eb78d21e6113454047dba7316c6e).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22890: [SPARK-25883][SQL][Minor] Override method `prettyName` i...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22890
  
    **[Test build #98264 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98264/testReport)** for PR 22890 at commit [`0393510`](https://github.com/apache/spark/commit/0393510c2e06eb78d21e6113454047dba7316c6e).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22890: [SPARK-25883][SQL][Minor] Override method `prettyName` i...

Posted by gengliangwang <gi...@git.apache.org>.

Github user gengliangwang commented on the issue:

    https://github.com/apache/spark/pull/22890
  
    This PR turn out to be a bug fix for this issue:
    https://issues.apache.org/jira/browse/SPARK-26063
    
    Back port this to branch-2.4.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org