You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/11/04 00:55:30 UTC

[GitHub] [nifi] mtien-apache commented on pull request #4630: NIFI-7924: add fallback claims for identifying user

mtien-apache commented on pull request #4630:
URL: https://github.com/apache/nifi/pull/4630#issuecomment-721452676


   @sjyang18 Thank you for submitting this. I've reviewed it and the functionality LGTM. I verified I can log in with OIDC enabled and verified the tests will use the listed fallback claim when email is not available.
   
   One suggestion is to update the NiFi docs with a description of the new fallback claim property. Here's a link to the docs section I'm referring to:
   
   http://nifi.apache.org/docs/nifi-docs/html/administration-guide.html#openid_connect
   
   I can give a +1 once this is updated. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org