You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/16 18:10:00 UTC
[jira] [Commented] (NIFI-5514) MergeRecord does not create a merged
FlowFile until a maximum threshold is reached
[ https://issues.apache.org/jira/browse/NIFI-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582884#comment-16582884 ]
ASF GitHub Bot commented on NIFI-5514:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2954
NIFI-5514: Fixed bugs in MergeRecord around minimum thresholds not be…
…ing honored and validation not being performed to ensure that minimum threshold is smaller than max threshold (would previously allow min record = 100, max records = 2 as a valid configuration)
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-5514
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2954.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2954
----
commit 8f13109e9064c6721f3bcb3dc472ec94e481835b
Author: Mark Payne <ma...@...>
Date: 2018-08-16T18:08:43Z
NIFI-5514: Fixed bugs in MergeRecord around minimum thresholds not being honored and validation not being performed to ensure that minimum threshold is smaller than max threshold (would previously allow min record = 100, max records = 2 as a valid configuration)
----
> MergeRecord does not create a merged FlowFile until a maximum threshold is reached
> ----------------------------------------------------------------------------------
>
> Key: NIFI-5514
> URL: https://issues.apache.org/jira/browse/NIFI-5514
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Major
>
> MergeRecord allows the user to specify a minimum number of records. However, if the minimum number of records is reached, the merged FlowFile is not created unless the maximum number of records or max number of bytes is also reached.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)