You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/06/16 17:07:05 UTC
[GitHub] [airflow] potiuk opened a new pull request, #31965: Skip python version check in some pre-commit when loading setup.py
potiuk opened a new pull request, #31965:
URL: https://github.com/apache/airflow/pull/31965
Some providers are excluded for some versions of Python (for example the `apache.hive` provider is excluded on Python 3.11. However this might make some pre-commits confused when running on Python 3.11 because the list of generated extras will be different for them than those on other Python versions.
We do not want to set python used in pre-commits to, say, python3.8, because that would mean that would require our users to have python3.8 as binary available on their system, which is not always setup. Python3 on the other hand is going to be universally available.
In order to mitigate the problem we will run the precommits with _SKIP_PYTHON_VERSION_CHECK variable set before import of setup is done, so that the python version check is skipped and all python versions will produce the same set of extras.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #31965: Skip python version check in some pre-commit when loading setup.py
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #31965:
URL: https://github.com/apache/airflow/pull/31965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org