You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ro...@apache.org on 2017/11/07 09:18:33 UTC

[sling-org-apache-sling-auth-form] 16/26: Don't quote cookie value and attributes

This is an automated email from the ASF dual-hosted git repository.

rombert pushed a commit to annotated tag org.apache.sling.auth.form-1.0.2
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-auth-form.git

commit b0873022b208420b7f0412d7d75d63efbdf2424b
Author: Felix Meschberger <fm...@apache.org>
AuthorDate: Sat Sep 18 18:08:58 2010 +0000

    Don't quote cookie value and attributes
    
    git-svn-id: https://svn.apache.org/repos/asf/sling/trunk/bundles/auth/form@998508 13f79535-47bb-0310-9956-ffa450edef68
---
 .../apache/sling/auth/form/impl/FormAuthenticationHandler.java    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/sling/auth/form/impl/FormAuthenticationHandler.java b/src/main/java/org/apache/sling/auth/form/impl/FormAuthenticationHandler.java
index 4415c33..3feb882 100644
--- a/src/main/java/org/apache/sling/auth/form/impl/FormAuthenticationHandler.java
+++ b/src/main/java/org/apache/sling/auth/form/impl/FormAuthenticationHandler.java
@@ -994,18 +994,18 @@ public class FormAuthenticationHandler extends AbstractAuthenticationHandler {
             final StringBuilder header = new StringBuilder();
 
             // default setup with name, value, cookie path and HttpOnly
-            header.append(name).append("=\"").append(value).append('"');
-            header.append("; Path=\"").append(cookiePath).append('"');
+            header.append(name).append("=").append(value);
+            header.append("; Path=").append(cookiePath);
             header.append("; HttpOnly"); // don't allow JS access
 
             // set the cookie domain if so configured
             if (domain != null) {
-                header.append("; Domain=\"").append(domain).append('"');
+                header.append("; Domain=").append(domain);
             }
 
             // Only set the Max-Age attribute to remove the cookie
             if (age >= 0) {
-                header.append("; Max-Age=\"").append(age).append('"');
+                header.append("; Max-Age=").append(age);
             }
 
             // ensure the cookie is secured if this is an https request

-- 
To stop receiving notification emails like this one, please contact
"commits@sling.apache.org" <co...@sling.apache.org>.