You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "zhongqiangczq (via GitHub)" <gi...@apache.org> on 2023/05/28 06:00:56 UTC
[GitHub] [incubator-celeborn] zhongqiangczq opened a new pull request, #1520: [CELEBORN-618] [FLINK] worker side adds partition split configuration options
zhongqiangczq opened a new pull request, #1520:
URL: https://github.com/apache/incubator-celeborn/pull/1520
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
now flink client hasn't support partition split, so server side add a configuration to close split.
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1520: [CELEBORN-618] [FLINK] worker side adds partition split configuration options
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1520:
URL: https://github.com/apache/incubator-celeborn/pull/1520#discussion_r1209674997
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -76,6 +77,7 @@ class PushDataHandler extends BaseMessageHandler with Logging {
storageManager = worker.storageManager
shutdown = worker.shutdown
conf = worker.conf
+ workerPartitionSplitEnabled = conf.workerPushHeartbeatEnabled
Review Comment:
typo? should be ```workerPartitionSplitEnabled```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zhongqiangczq commented on a diff in pull request #1520: [CELEBORN-618] [FLINK] worker side adds partition split configuration options
Posted by "zhongqiangczq (via GitHub)" <gi...@apache.org>.
zhongqiangczq commented on code in PR #1520:
URL: https://github.com/apache/incubator-celeborn/pull/1520#discussion_r1209720267
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -76,6 +77,7 @@ class PushDataHandler extends BaseMessageHandler with Logging {
storageManager = worker.storageManager
shutdown = worker.shutdown
conf = worker.conf
+ workerPartitionSplitEnabled = conf.workerPushHeartbeatEnabled
Review Comment:
yes. it's my fault. it has been corrected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1520: [CELEBORN-618] [FLINK] worker side adds partition split configuration options
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1520:
URL: https://github.com/apache/incubator-celeborn/pull/1520#discussion_r1209680021
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -76,6 +77,7 @@ class PushDataHandler extends BaseMessageHandler with Logging {
storageManager = worker.storageManager
shutdown = worker.shutdown
conf = worker.conf
+ workerPartitionSplitEnabled = conf.workerPushHeartbeatEnabled
Review Comment:
typo? should be workerPartitionSplitEnabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1520: [CELEBORN-618] [FLINK] worker side adds partition split configuration options
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1520:
URL: https://github.com/apache/incubator-celeborn/pull/1520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1520: [CELEBORN-618] [FLINK] worker side adds partition split configuration options
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1520:
URL: https://github.com/apache/incubator-celeborn/pull/1520#issuecomment-1567703892
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1520?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1520](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1520?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4e96c46) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/d30f45ad63aaccdb164f1d2b9b45338f1c66f67e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d30f45a) will **decrease** coverage by `0.01%`.
> The diff coverage is `85.72%`.
```diff
@@ Coverage Diff @@
## main #1520 +/- ##
==========================================
- Coverage 45.30% 45.29% -0.01%
==========================================
Files 158 158
Lines 9769 9776 +7
Branches 967 967
==========================================
+ Hits 4425 4427 +2
- Misses 5044 5049 +5
Partials 300 300
```
| [Impacted Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...cala/org/apache/celeborn/common/CelebornConf.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | `87.40% <85.72%> (-<0.01%)` | :arrow_down: |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1520/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1520: [CELEBORN-618] [FLINK] worker side adds partition split configuration options
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1520:
URL: https://github.com/apache/incubator-celeborn/pull/1520#discussion_r1209674997
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -76,6 +77,7 @@ class PushDataHandler extends BaseMessageHandler with Logging {
storageManager = worker.storageManager
shutdown = worker.shutdown
conf = worker.conf
+ workerPartitionSplitEnabled = conf.workerPushHeartbeatEnabled
Review Comment:
typo? should be ```workerPartitionSplitEnabled```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org