You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sanpwc (via GitHub)" <gi...@apache.org> on 2025/08/07 08:14:44 UTC
[PR] IGNITE-26121 Print warning message if MAX_CLOCK_SKEW exceeded [ignite-3]
sanpwc opened a new pull request, #6376:
URL: https://github.com/apache/ignite-3/pull/6376
https://issues.apache.org/jira/browse/IGNITE-26121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26121 Print warning message if MAX_CLOCK_SKEW exceeded [ignite-3]
Posted by "sanpwc (via GitHub)" <gi...@apache.org>.
sanpwc commented on code in PR #6376:
URL: https://github.com/apache/ignite-3/pull/6376#discussion_r2279135351
##########
modules/core/src/main/java/org/apache/ignite/internal/hlc/ClockServiceImpl.java:
##########
@@ -70,6 +85,11 @@ public CompletableFuture<Void> waitFor(HybridTimestamp targetTimestamp) {
@Override
public long maxClockSkewMillis() {
- return maxClockSkewMsSupplier.getAsLong();
+ // -1 is an invalid maxClockSkewMillis, thus it might be used as a special "non-initialized" value.
+ if (maxClockSkewMillis == -1) {
+ maxClockSkewMillis = maxClockSkewMsSupplier.getAsLong();
+ }
+
+ return maxClockSkewMillis;
Review Comment:
Discussed in private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26121 Print warning message if MAX_CLOCK_SKEW exceeded [ignite-3]
Posted by "sanpwc (via GitHub)" <gi...@apache.org>.
sanpwc merged PR #6376:
URL: https://github.com/apache/ignite-3/pull/6376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26121 Print warning message if MAX_CLOCK_SKEW exceeded [ignite-3]
Posted by "vldpyatkov (via GitHub)" <gi...@apache.org>.
vldpyatkov commented on code in PR #6376:
URL: https://github.com/apache/ignite-3/pull/6376#discussion_r2279013399
##########
modules/core/src/main/java/org/apache/ignite/internal/hlc/ClockServiceImpl.java:
##########
@@ -70,6 +85,11 @@ public CompletableFuture<Void> waitFor(HybridTimestamp targetTimestamp) {
@Override
public long maxClockSkewMillis() {
- return maxClockSkewMsSupplier.getAsLong();
+ // -1 is an invalid maxClockSkewMillis, thus it might be used as a special "non-initialized" value.
+ if (maxClockSkewMillis == -1) {
+ maxClockSkewMillis = maxClockSkewMsSupplier.getAsLong();
+ }
+
+ return maxClockSkewMillis;
Review Comment:
I’m not sure this is the correct way because we had the option to update maxClockSkew through the configuration. It would be even better to add a listener for the system property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org