You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Gilvan Filho (Jira)" <ji...@apache.org> on 2022/10/28 17:12:00 UTC

[jira] [Commented] (CAMEL-18646) camel-git - Provide custom configuration

    [ https://issues.apache.org/jira/browse/CAMEL-18646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625818#comment-17625818 ] 

Gilvan Filho commented on CAMEL-18646:
--------------------------------------

I was looking on that and once JGit don't allow (or I did not find a way to) inject {{org.eclipse.jgit.lib.StoreConfig}} I think remain two options:

1 - Allow user pass a {{org.eclipse.jgit.lib.Repository}} to camel use it
2 - Allow user pass a {{.gitconfig}} file through a {{java.io.File}} or it path as {{String}} and use it in a Custom {{org.eclipse.jgit.utilSystemReader}}

First option, pass a {{Repository}}, would allow users create that as they want, giving them more flexibility but require more knowledge about JGit internals. Moreover {{localPath}} path parameter would no longer be mandatory.

With second option, pass a {{File}}, users would need to pass a File (or it path) and dont worry about JGit internals. More simples but less flexible (for user). However that way camel-git will turn more coupled with JGit once will be needed to extend one JGit internal class (SystemReader).

What's the best alternative?

> camel-git - Provide custom configuration
> ----------------------------------------
>
>                 Key: CAMEL-18646
>                 URL: https://issues.apache.org/jira/browse/CAMEL-18646
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-git
>    Affects Versions: 3.19.0
>            Reporter: Federico Mariani
>            Priority: Major
>
> let camel users provide a custom git configuration, for example, disable SSL verification.
> https://git.eclipse.org/r/plugins/gitiles/jgit/jgit/+/refs/heads/master/Documentation/config-options.md



--
This message was sent by Atlassian Jira
(v8.20.10#820010)