[GitHub] [superset] kgabryje commented on a diff in pull request #25372: fix(SqlLab): make icon placement even

["kgabryje (via GitHub)" <gi...@apache.org>]

kgabryje commented on code in PR #25372:
URL: https://github.com/apache/superset/pull/25372#discussion_r1336095383


##########
superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx:
##########
@@ -85,7 +85,9 @@ const collapseStyles = (theme: SupersetTheme) => css`
     padding: 0px ${theme.gridUnit * 4}px 0px 0px !important;
   }
   .ant-collapse-arrow {
-    top: ${theme.gridUnit * 2}px !important;
+    padding: ${theme.gridUnit / 2}px 0 !important;
+    bottom: ${theme.gridUnit}px !important;
+    right: ${theme.gridUnit * 4}px !important;

Review Comment:
   Do we actually need those styles? It looks like the arrow is correctly centred when you just remove the padding (see screenshot).
   
   <img width="1546" alt="image" src="https://github.com/apache/superset/assets/15073128/b27d1331-aea3-4447-b39f-6c7c35e099cd">
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org