You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/08/28 23:54:42 UTC

Review Request 37907: Libevent: Used `evutil_gettimeofday` to implement `time()`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37907/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Bugs: MESOS-3189
    https://issues.apache.org/jira/browse/MESOS-3189


Repository: mesos


Description
-------

This used to be implemented by `event_base_gettimeofday_cached()`. We
want to avoid cached results in case they introduce any issues.


Diffs
-----

  3rdparty/libprocess/src/libevent.cpp d7c47fbd1dbdec1fc974840e6f3a1428a8f189d5 

Diff: https://reviews.apache.org/r/37907/diff/


Testing
-------

`./tests --gtest_repeat=10000 --gtest_filter="TimeTest.Now" --gtest_throw_on_failure`


Thanks,

Joris Van Remoortere

Re: Review Request 37907: Libevent: Used `evutil_gettimeofday` to implement `time()`.

Posted by Benjamin Hindman <be...@berkeley.edu>.


> On Aug. 28, 2015, 11:49 p.m., Vinod Kone wrote:
> > Are there any libevent benchmark tests that we can validate this against?

We don't use a cached value with libev either.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37907/#review96955
-----------------------------------------------------------


On Aug. 28, 2015, 9:54 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37907/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 9:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-3189
>     https://issues.apache.org/jira/browse/MESOS-3189
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This used to be implemented by `event_base_gettimeofday_cached()`. We
> want to avoid cached results in case they introduce any issues.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/libevent.cpp d7c47fbd1dbdec1fc974840e6f3a1428a8f189d5 
> 
> Diff: https://reviews.apache.org/r/37907/diff/
> 
> 
> Testing
> -------
> 
> `./tests --gtest_repeat=10000 --gtest_filter="TimeTest.Now" --gtest_throw_on_failure`
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37907: Libevent: Used `evutil_gettimeofday` to implement `time()`.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37907/#review96955
-----------------------------------------------------------

Ship it!


Are there any libevent benchmark tests that we can validate this against?

- Vinod Kone


On Aug. 28, 2015, 9:54 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37907/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 9:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-3189
>     https://issues.apache.org/jira/browse/MESOS-3189
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This used to be implemented by `event_base_gettimeofday_cached()`. We
> want to avoid cached results in case they introduce any issues.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/libevent.cpp d7c47fbd1dbdec1fc974840e6f3a1428a8f189d5 
> 
> Diff: https://reviews.apache.org/r/37907/diff/
> 
> 
> Testing
> -------
> 
> `./tests --gtest_repeat=10000 --gtest_filter="TimeTest.Now" --gtest_throw_on_failure`
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37907: Libevent: Used `evutil_gettimeofday` to implement `time()`.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37907/#review96943
-----------------------------------------------------------


Patch looks great!

Reviews applied: [37907]

All tests passed.

- Mesos ReviewBot


On Aug. 28, 2015, 9:54 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37907/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 9:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-3189
>     https://issues.apache.org/jira/browse/MESOS-3189
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This used to be implemented by `event_base_gettimeofday_cached()`. We
> want to avoid cached results in case they introduce any issues.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/libevent.cpp d7c47fbd1dbdec1fc974840e6f3a1428a8f189d5 
> 
> Diff: https://reviews.apache.org/r/37907/diff/
> 
> 
> Testing
> -------
> 
> `./tests --gtest_repeat=10000 --gtest_filter="TimeTest.Now" --gtest_throw_on_failure`
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37907: Libevent: Used `evutil_gettimeofday` to implement `time()`.

Posted by Benjamin Hindman <be...@berkeley.edu>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37907/#review97045
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Aug. 28, 2015, 9:54 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37907/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 9:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-3189
>     https://issues.apache.org/jira/browse/MESOS-3189
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This used to be implemented by `event_base_gettimeofday_cached()`. We
> want to avoid cached results in case they introduce any issues.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/libevent.cpp d7c47fbd1dbdec1fc974840e6f3a1428a8f189d5 
> 
> Diff: https://reviews.apache.org/r/37907/diff/
> 
> 
> Testing
> -------
> 
> `./tests --gtest_repeat=10000 --gtest_filter="TimeTest.Now" --gtest_throw_on_failure`
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>