You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2014/03/07 17:02:39 UTC
[jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds-karaf digitalocean-fix
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-karaf/pull/38
-- Commit Summary --
* Added missing DigitalOcean feature to features/pom.xml
-- File Changes --
M feature/pom.xml (1)
-- Patch Links --
https://github.com/jclouds/jclouds-karaf/pull/38.patch
https://github.com/jclouds/jclouds-karaf/pull/38.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Andrew Phillips <no...@github.com>.
Let me bounce this - changed the DEV@cloud builds to use a workspace-local repo.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38#issuecomment-37107307
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Andrew Phillips <no...@github.com>.
> jclouds-karaf-pull-requests #46 ABORTED
Some internal error. Let's try that again...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38#issuecomment-37109231
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Andrew Phillips <no...@github.com>.
Reopened #38.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Ignasi Barrera <no...@github.com>.
Many thanks! I'll open the PR for the CLI and then backport all these to 1.7.x, as DO is already available there.
What was then the effect of that property change? Just to understand what has ben fixed and what wasn't properly configured :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38#issuecomment-37757394
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-karaf #787](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/787/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38#issuecomment-37048003
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -158,6 +158,7 @@ limitations under the License.
> <feature>jclouds-serverlove-z1-man</feature>
> <feature>jclouds-skalicloud-sdg-my</feature>
> <feature>jclouds-softlayer</feature>
> + <feature>jclouds-digitalocean</feature>
Let's see first if this fix my total fail at getting started with jclouds-karaf ^^
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38/files#r10388057
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Andrew Phillips <no...@github.com>.
Reopened #38.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Andrew Phillips <no...@github.com>.
OK, it appears this build requires the maven repo to be `~/.m2/repository`, which seems a bit fishy?
@iocanel: do you have any more details about how the itests expect Maven to be set up?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38#issuecomment-37111666
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Andrew Phillips <no...@github.com>.
The code change certainly did something, though:
```
[INFO] --- features-maven-plugin:2.3.2:add-features-to-repo (add-features-to-repo) @ jclouds-karaf ---
[INFO] Copying bundle: org.apache.karaf.assemblies.features:standard:xml:features:2.3.2
[INFO] Copying bundle: org.apache.karaf.assemblies.features:enterprise:xml:features:2.3.2
[INFO] Copying bundle: org.apache.karaf.assemblies.features:enterprise:xml:features:2.3.2
[INFO] Copying bundle: org.apache.karaf.assemblies.features:standard:xml:features:2.3.2
...
[INFO] Adding contents of transitive feature: jclouds-digitalocean/1.8.0-SNAPSHOT
```
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38#issuecomment-37088038
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-karaf-pull-requests #47](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/47/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38#issuecomment-37109596
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Andrew Phillips <no...@github.com>.
> jclouds-karaf-pull-requests #47 UNSTABLE
Great. Now (with a local repo) **all** the itests are barfing. It's not even able to find the features now:
```
karaf@root> features:addurl mvn:org.apache.jclouds.karaf/jclouds-karaf/1.8.0-SNAPSHOT/xml/features
org.apache.karaf.shell.console.MultiException: Unable to add repositories:
URL [mvn:org.apache.jclouds.karaf/jclouds-karaf/1.8.0-SNAPSHOT/xml/features] could not be resolved.
```
even though there certainly appears to be an XML file in the local repo:
https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/ws/.repository/org/apache/jclouds/karaf/jclouds-karaf/1.8.0-SNAPSHOT/jclouds-karaf-1.8.0-SNAPSHOT-features.xml
@iocanel: do you have any ideas what could be going on here, or which properties we would need to set/override to get this to work?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38#issuecomment-37110148
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Andrew Phillips <no...@github.com>.
> @@ -158,6 +158,7 @@ limitations under the License.
> <feature>jclouds-serverlove-z1-man</feature>
> <feature>jclouds-skalicloud-sdg-my</feature>
> <feature>jclouds-softlayer</feature>
> + <feature>jclouds-digitalocean</feature>
[minor] Can you move it into the alphabetically correct location when you merge? Let's first of all see what the PR builders say, though.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38/files#r10387679
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Andrew Phillips <no...@github.com>.
[With Java 6](https://jclouds.ci.cloudbees.com/view/integrations/job/jclouds-karaf-do-java-6/1/console): also works!
```
karaf@root> features:addurl mvn:org.apache.jclouds.karaf/jclouds-karaf/1.8.0-SNAPSHOT/xml/features
features:install jclouds-digitalocean
osgi:list -t 0
START LEVEL 100 , List Threshold: 0
ID State Blueprint Level Name
[ 0] [Active ] [ ] [ 0] System Bundle (4.0.3)
...
[ 84] [Active ] [ ] [ 80] jclouds Components Core (1.8.0.SNAPSHOT)
[ 85] [Active ] [ ] [ 80] jclouds Log4J Logging Module (1.8.0.SNAPSHOT)
[ 86] [Active ] [ ] [ 80] jclouds script builder (1.8.0.SNAPSHOT)
[ 87] [Active ] [ ] [ 80] jclouds compute core (1.8.0.SNAPSHOT)
[ 88] [Active ] [ ] [ 80] jclouds DigitalOcean Provider (1.8.0.SNAPSHOT)
...
[INFO] Reactor Summary:
[INFO]
[INFO] Apache jclouds :: Karaf ........................... SUCCESS [23.924s]
[INFO] jclouds :: Karaf :: Core .......................... SUCCESS [15.914s]
[INFO] jclouds :: Karaf :: Utils ......................... SUCCESS [8.173s]
[INFO] jclouds :: Karaf :: Recipe ........................ SUCCESS [6.075s]
[INFO] jclouds :: Karaf :: Cache ......................... SUCCESS [6.683s]
[INFO] jclouds :: Karaf :: Services ...................... SUCCESS [24.769s]
[INFO] jclouds :: Karaf :: Commands ...................... SUCCESS [24.977s]
[INFO] jclouds :: Karaf :: URL Handler ................... SUCCESS [3.942s]
[INFO] jclouds :: Karaf :: Chef .......................... SUCCESS [0.164s]
[INFO] jclouds :: Karaf :: Chef :: Core .................. SUCCESS [5.195s]
[INFO] jclouds :: Karaf :: Chef :: Services .............. SUCCESS [5.221s]
[INFO] jclouds :: Karaf :: Chef :: Commands .............. SUCCESS [11.550s]
[INFO] jclouds :: Karaf :: Chef :: Cache ................. SUCCESS [3.993s]
[INFO] jclouds :: Karaf :: Feature ....................... SUCCESS [36.828s]
[INFO] jclouds :: Karaf :: Integration Tests ............. SUCCESS [56:09.286s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 59:46.367s
[INFO] Finished at: Sat Mar 15 21:13:47 EDT 2014
```
So this is +1 - good to go for me!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38#issuecomment-37748075
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-karaf-pull-requests #46](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/46/) ABORTED
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38#issuecomment-37108078
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Andrew Phillips <no...@github.com>.
Slightly more interesting (same plugin invocation):
```
[INFO] Base repo: file:///scratch/jenkins/workspace/jclouds-karaf-pull-requests/.repository/
```
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38#issuecomment-37088132
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-karaf #790](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/790/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38#issuecomment-37108765
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-karaf-pull-requests #45](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/45/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38#issuecomment-37045445
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Andrew Phillips <no...@github.com>.
> jclouds-karaf-pull-requests #45 UNSTABLE
Still [the same failure](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/org.apache.jclouds.karaf$itests/45/testReport/junit/org.jclouds.karaf.itests/MiscFeaturesInstallationTest/testDigitalOceanFeature_org_jclouds_karaf_itests_MiscFeaturesInstallationTest_testDigitalOceanFeature_KarafTestContainer_mvn_org_apache_karaf__apache_karaf__2_3_2__tar_gz_/). And some others, actually. Weird
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38#issuecomment-37088013
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Andrew Phillips <no...@github.com>.
Running this now using `clean verify -e -U -Dmaven.javadoc.skip=true` in the [jclouds-karaf-java-7 job](https://jclouds.ci.cloudbees.com/view/integrations/job/jclouds-karaf-java-7) rather than the pull request builder. I think this may succeed, in which case I think we should be good to merge this:
https://jclouds.ci.cloudbees.com/view/integrations/job/jclouds-karaf-java-7/402/console
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38#issuecomment-37741193
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -158,6 +158,7 @@ limitations under the License.
> <feature>jclouds-serverlove-z1-man</feature>
> <feature>jclouds-skalicloud-sdg-my</feature>
> <feature>jclouds-softlayer</feature>
> + <feature>jclouds-digitalocean</feature>
Yep, will add the commit to sort to this PR and merge without squashing into a single one
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38/files#r10388033
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Andrew Phillips <no...@github.com>.
> What was then the effect of that property change? Just to understand what has ben fixed and what
> wasn't properly configured :)
I wish I could confidently give you an accurate answer. But without the addition tests were reproducibly failing, and with the change things seem to succeed. That's about as much as I can gather :-(
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38#issuecomment-37757678
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Andrew Gaul <no...@github.com>.
> @@ -158,6 +158,7 @@ limitations under the License.
> <feature>jclouds-serverlove-z1-man</feature>
> <feature>jclouds-skalicloud-sdg-my</feature>
> <feature>jclouds-softlayer</feature>
> + <feature>jclouds-digitalocean</feature>
Definitely prefer sorted, although can you do this in a subsequent commit?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38/files#r10387852
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-karaf #791](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/791/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38#issuecomment-37110516
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Andrew Phillips <no...@github.com>.
Tadaaa!
```
karaf@root> features:addurl mvn:org.apache.jclouds.karaf/jclouds-karaf/1.8.0-SNAPSHOT/xml/features
features:install jclouds-digitalocean
osgi:list -t 0
START LEVEL 100 , List Threshold: 0
ID State Blueprint Level Name
[ 0] [Active ] [ ] [ 0] System Bundle (4.0.3)
...
[ 84] [Active ] [ ] [ 80] jclouds Components Core (1.8.0.SNAPSHOT)
[ 85] [Active ] [ ] [ 80] jclouds Log4J Logging Module (1.8.0.SNAPSHOT)
[ 86] [Active ] [ ] [ 80] jclouds script builder (1.8.0.SNAPSHOT)
[ 87] [Active ] [ ] [ 80] jclouds compute core (1.8.0.SNAPSHOT)
[ 88] [Active ] [ ] [ 80] jclouds DigitalOcean Provider (1.8.0.SNAPSHOT)
Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 839.823 sec
...
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 18 licence.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache jclouds :: Karaf ........................... SUCCESS [20.901s]
[INFO] jclouds :: Karaf :: Core .......................... SUCCESS [17.119s]
[INFO] jclouds :: Karaf :: Utils ......................... SUCCESS [8.808s]
[INFO] jclouds :: Karaf :: Recipe ........................ SUCCESS [5.359s]
[INFO] jclouds :: Karaf :: Cache ......................... SUCCESS [5.570s]
[INFO] jclouds :: Karaf :: Services ...................... SUCCESS [35.590s]
[INFO] jclouds :: Karaf :: Commands ...................... SUCCESS [32.779s]
[INFO] jclouds :: Karaf :: URL Handler ................... SUCCESS [5.201s]
[INFO] jclouds :: Karaf :: Chef .......................... SUCCESS [0.175s]
[INFO] jclouds :: Karaf :: Chef :: Core .................. SUCCESS [8.383s]
[INFO] jclouds :: Karaf :: Chef :: Services .............. SUCCESS [6.449s]
[INFO] jclouds :: Karaf :: Chef :: Commands .............. SUCCESS [9.326s]
[INFO] jclouds :: Karaf :: Chef :: Cache ................. SUCCESS [3.921s]
[INFO] jclouds :: Karaf :: Feature ....................... SUCCESS [1:41.352s]
[INFO] jclouds :: Karaf :: Integration Tests ............. SUCCESS [44:18.114s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 49:11.479s
[INFO] Finished at: Sat Mar 15 20:03:52 EDT 2014
[INFO] Final Memory: 95M/258M
[INFO] ------------------------------------------------------------------------
```
No idea what the PR builder is complaining about :-( One final test...with JDK 6.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38#issuecomment-37743497
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Andrew Phillips <no...@github.com>.
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-karaf.git;a=commit;h=1f6b0b32e7889a25ee3b113725a471ce6f3abb07). Thanks, @nacx!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38#issuecomment-37757343
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -158,6 +158,7 @@ limitations under the License.
> <feature>jclouds-serverlove-z1-man</feature>
> <feature>jclouds-skalicloud-sdg-my</feature>
> <feature>jclouds-softlayer</feature>
> + <feature>jclouds-digitalocean</feature>
The feature list is not alphabetically sorted... but can sort it :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38/files#r10387706
Re: [jclouds-karaf] Added missing DigitalOcean feature to
features/pom.xml (#38)
Posted by Andrew Phillips <no...@github.com>.
Closed #38.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/38