You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/05/13 15:01:44 UTC

[GitHub] [activemq-artemis] gemmellr opened a new pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

gemmellr opened a new pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578


   These initial changes get things building on Java 16 (and 17EA+21)
   
   Updates the parent pom and various plugins or deps, tidies up some elements of the poms and consolidates to inherit plugin versions from the parent where possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr commented on pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-842127703






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr commented on pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-843432810


   Yep, as discussed elsewhere it would be good to rename the maven and java version enforcer checks to add '-version' to the execution id, will be clearer and consistent with the parent pom run, avoiding the effectively duplicate run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic merged pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

Posted by GitBox <gi...@apache.org>.
clebertsuconic merged pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr commented on pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-842127703


   FWIW, I did a _"mvn clean install -Derrorprone -Ptests -Ptests-CI -Pjmh"_ run on JDK8 with these changes the other day which passed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] jbertram commented on pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-840692218


   This should replace #3502, no?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] brusdev commented on pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-844118991


   @gemmellr I have just created the #3587 PR to align the enforcer ids.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr commented on pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-841196705


   Irony..part of the changes made in #3579 (which I just merged) to get some Kerberos tests working on JDK11+, does not work on 16 and an updated dep has also stopped other tests running on JDK16 that are in the PR build..
   
   I shall begin investigating relevant module access config or test exclusion workarounds now :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr edited a comment on pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

Posted by GitBox <gi...@apache.org>.
gemmellr edited a comment on pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-841196705


   Irony..part of the changes made in #3579 (which I just merged) to get some Kerberos tests working on JDK11+, does not work on 16 and an updated dep has also stopped other existing related tests that are in the PR build from succeeding on JDK16 so that bit of the build failed after I rebased this.
   
   I shall begin investigating relevant module access config or test exclusion workarounds  :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr commented on pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-840699122


   Yes, I originally meant to mention it and forgot to.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr commented on pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-841258075


   Added another commit with changes to hopefully address that.
   
   I dropped the Apache DS dep back 1 version (meaning it went from M15 originally up to 25 now, instead of 26) to remove the more general issue it added that was affecting the multiple existing tests. That issue has been fixed towards the next DS release but they have just removed [1] other functionality the test is using from it, so that release isnt going to be an option and the test will need removed/redone in future.
   
   With that problem resolved, there was indeed a test-specific issue remaining with that second kerberos on JDK16 needing addressed, with its access of classes now guarded since JDK16, so I added an export for that to let it run and it now passed locally.
   
   [1]https://github.com/apache/directory-server/commit/bb6db861681951c930941ed4bb92fd358fa333ec


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr commented on pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-840623854


   Although they build, the tests in the cdi and compatibility-tests modules are disabled when running on Java 16 as they dont work yet. More work can perhaps get them going later. 
   
   For the compatibility-tests, upgrading groovy to a version got them into a more functional state, but they then got into a scenario where they appeared to be doing an infinite reconnect loop (mismatching client and server version failure was noted) and they repeatedly threw OOM errors also.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr commented on pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-842128951


   Rebased to current main and squashed the 2 commits.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr commented on pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-844119848


   @brusdev already pushed it ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-842284871


   @gemmellr thanks as usual Robbie


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr commented on pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-843112963


   Small fixup made in https://github.com/apache/activemq-artemis/commit/7733a76649403193e0e0e7e1a6279095fdbf426c around script permissions in the binary assembly, after issue was raised via #3585


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-842284871


   @gemmellr thanks as usual Robbie


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr commented on pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-841298809


   Looks like the GitHub Actions build itself is a bit broken (also doing same with a different build, https://github.com/apache/activemq-artemis/actions/runs/842401037). The subjobs were 'starting' (rather than just queued) since I pushed and the 16 job eventually failed seemingly without doing anything.
   
   Travis passed for the main repo, and both Travis and GHA and Travis passed for my fork when the the commits were pushed:
   https://github.com/gemmellr/activemq-artemis/actions/runs/842347976
   https://travis-ci.org/github/gemmellr/activemq-artemis/builds/771137254?utm_source=github_status&utm_medium=notification


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic merged pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

Posted by GitBox <gi...@apache.org>.
clebertsuconic merged pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] brusdev commented on pull request #3578: ARTEMIS-3296: get things building on Java 16 (and 17EA+21)

Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3578:
URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-843426112


   @gemmellr the version 23 of the org.apache parent pom includes an execution of the maven-enforcer-plugin with an id different from the id defined in the artemis pom and this is causing duplicate runs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org