You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/24 03:13:05 UTC
[GitHub] [incubator-superset] mistercrunch opened a new pull request #11787: fix: annotation layer crashes when clearing type select
mistercrunch opened a new pull request #11787:
URL: https://github.com/apache/incubator-superset/pull/11787
### SUMMARY
closes #11759, simply removing the possibility on "clearing" the <Select>s
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="883" alt="Screen Shot 2020-11-23 at 7 11 31 PM" src="https://user-images.githubusercontent.com/487433/100042205-d7f39380-2dbf-11eb-8c73-8211078ecb73.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on pull request #11787: fix: annotation layer crashes when clearing type select
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #11787:
URL: https://github.com/apache/incubator-superset/pull/11787#issuecomment-732638619
thank you @mistercrunch!! 🙏 tested, LGTM. there are still other bugs in annotation modal, the outsourcing team should be able to tackle the rest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on pull request #11787: fix: annotation layer crashes when clearing type select
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #11787:
URL: https://github.com/apache/incubator-superset/pull/11787#issuecomment-732638619
thank you @mistercrunch!! 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc removed a comment on pull request #11787: fix: annotation layer crashes when clearing type select
Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on pull request #11787:
URL: https://github.com/apache/incubator-superset/pull/11787#issuecomment-732638619
thank you @mistercrunch!! 🙏 tested, LGTM. there are still other bugs in annotation modal, the outsourcing team should be able to tackle the rest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud merged pull request #11787: fix: annotation layer crashes when clearing type select
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #11787:
URL: https://github.com/apache/incubator-superset/pull/11787
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org