You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Arjun Mishra via Review Board <no...@reviews.apache.org> on 2019/07/09 15:00:31 UTC
Review Request 71039: SENTRY-2528: Format exception when fetching a
full snapshot
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71039/
-----------------------------------------------------------
Review request for sentry and kalyan kumar kalvagadda.
Bugs: SENTRY-2528
https://issues.apache.org/jira/browse/SENTRY-2528
Repository: sentry
Description
-------
When fetching a full snapshot we get the below error. This is a regression of SENTRY-2301
2019-07-07 23:07:39,677 ERROR org.apache.sentry.service.thrift.SentryHMSClient: Snapshot created failed
java.util.IllegalFormatConversionException: f != java.lang.Long
at java.util.Formatter$FormatSpecifier.failConversion(Formatter.java:4302)
at java.util.Formatter$FormatSpecifier.printFloat(Formatter.java:2806)
at java.util.Formatter$FormatSpecifier.print(Formatter.java:2753)
at java.util.Formatter.format(Formatter.java:2520)
at java.util.Formatter.format(Formatter.java:2455)
at java.lang.String.format(String.java:2940)
at org.apache.sentry.service.thrift.FullUpdateInitializer.getFullHMSSnapshot(FullUpdateInitializer.java:552)
at org.apache.sentry.service.thrift.SentryHMSClient.fetchFullUpdate(SentryHMSClient.java:244)
at org.apache.sentry.service.thrift.SentryHMSClient.getFullSnapshot(SentryHMSClient.java:147)
at org.apache.sentry.provider.db.service.persistent.HMSFollower.createFullSnapshot(HMSFollower.java:409)
at org.apache.sentry.provider.db.service.persistent.HMSFollower.syncupWithHms(HMSFollower.java:237)
at org.apache.sentry.provider.db.service.persistent.HMSFollower.run(HMSFollower.java:198)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Diffs
-----
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java d4bca42faea51d87164568c23bd7849c56450f32
Diff: https://reviews.apache.org/r/71039/diff/1/
Testing
-------
Thanks,
Arjun Mishra
Re: Review Request 71039: SENTRY-2528: Format exception when fetching
a full snapshot
Posted by Arjun Mishra via Review Board <no...@reviews.apache.org>.
> On July 9, 2019, 6:39 p.m., kalyan kumar kalvagadda wrote:
> > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java
> > Line 548 (original), 548 (patched)
> > <https://reviews.apache.org/r/71039/diff/1/?file=2154106#file2154106line548>
> >
> > Consider changing it as below
> >
> > percentageDatabasesFetched = totalNumberOfDatabases > 0? ((totalNumberOfDatabasesFetched*100)/totalNumberOfDatabases):0;
> >
> >
> > This way you can avaoid the explicit casting. This applies below statements as well.
We need to cast else long/long will be a long and the decimal value will be dropped
- Arjun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71039/#review216448
-----------------------------------------------------------
On July 9, 2019, 3 p.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71039/
> -----------------------------------------------------------
>
> (Updated July 9, 2019, 3 p.m.)
>
>
> Review request for sentry and kalyan kumar kalvagadda.
>
>
> Bugs: SENTRY-2528
> https://issues.apache.org/jira/browse/SENTRY-2528
>
>
> Repository: sentry
>
>
> Description
> -------
>
> When fetching a full snapshot we get the below error. This is a regression of SENTRY-2301
>
> 2019-07-07 23:07:39,677 ERROR org.apache.sentry.service.thrift.SentryHMSClient: Snapshot created failed
> java.util.IllegalFormatConversionException: f != java.lang.Long
> at java.util.Formatter$FormatSpecifier.failConversion(Formatter.java:4302)
> at java.util.Formatter$FormatSpecifier.printFloat(Formatter.java:2806)
> at java.util.Formatter$FormatSpecifier.print(Formatter.java:2753)
> at java.util.Formatter.format(Formatter.java:2520)
> at java.util.Formatter.format(Formatter.java:2455)
> at java.lang.String.format(String.java:2940)
> at org.apache.sentry.service.thrift.FullUpdateInitializer.getFullHMSSnapshot(FullUpdateInitializer.java:552)
> at org.apache.sentry.service.thrift.SentryHMSClient.fetchFullUpdate(SentryHMSClient.java:244)
> at org.apache.sentry.service.thrift.SentryHMSClient.getFullSnapshot(SentryHMSClient.java:147)
> at org.apache.sentry.provider.db.service.persistent.HMSFollower.createFullSnapshot(HMSFollower.java:409)
> at org.apache.sentry.provider.db.service.persistent.HMSFollower.syncupWithHms(HMSFollower.java:237)
> at org.apache.sentry.provider.db.service.persistent.HMSFollower.run(HMSFollower.java:198)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java d4bca42faea51d87164568c23bd7849c56450f32
>
>
> Diff: https://reviews.apache.org/r/71039/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Mishra
>
>
Re: Review Request 71039: SENTRY-2528: Format exception when fetching
a full snapshot
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71039/#review216448
-----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java
Line 548 (original), 548 (patched)
<https://reviews.apache.org/r/71039/#comment303685>
Consider changing it as below
percentageDatabasesFetched = totalNumberOfDatabases > 0? ((totalNumberOfDatabasesFetched*100)/totalNumberOfDatabases):0;
This way you can avaoid the explicit casting. This applies below statements as well.
- kalyan kumar kalvagadda
On July 9, 2019, 3 p.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71039/
> -----------------------------------------------------------
>
> (Updated July 9, 2019, 3 p.m.)
>
>
> Review request for sentry and kalyan kumar kalvagadda.
>
>
> Bugs: SENTRY-2528
> https://issues.apache.org/jira/browse/SENTRY-2528
>
>
> Repository: sentry
>
>
> Description
> -------
>
> When fetching a full snapshot we get the below error. This is a regression of SENTRY-2301
>
> 2019-07-07 23:07:39,677 ERROR org.apache.sentry.service.thrift.SentryHMSClient: Snapshot created failed
> java.util.IllegalFormatConversionException: f != java.lang.Long
> at java.util.Formatter$FormatSpecifier.failConversion(Formatter.java:4302)
> at java.util.Formatter$FormatSpecifier.printFloat(Formatter.java:2806)
> at java.util.Formatter$FormatSpecifier.print(Formatter.java:2753)
> at java.util.Formatter.format(Formatter.java:2520)
> at java.util.Formatter.format(Formatter.java:2455)
> at java.lang.String.format(String.java:2940)
> at org.apache.sentry.service.thrift.FullUpdateInitializer.getFullHMSSnapshot(FullUpdateInitializer.java:552)
> at org.apache.sentry.service.thrift.SentryHMSClient.fetchFullUpdate(SentryHMSClient.java:244)
> at org.apache.sentry.service.thrift.SentryHMSClient.getFullSnapshot(SentryHMSClient.java:147)
> at org.apache.sentry.provider.db.service.persistent.HMSFollower.createFullSnapshot(HMSFollower.java:409)
> at org.apache.sentry.provider.db.service.persistent.HMSFollower.syncupWithHms(HMSFollower.java:237)
> at org.apache.sentry.provider.db.service.persistent.HMSFollower.run(HMSFollower.java:198)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java d4bca42faea51d87164568c23bd7849c56450f32
>
>
> Diff: https://reviews.apache.org/r/71039/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Mishra
>
>
Re: Review Request 71039: SENTRY-2528: Format exception when fetching
a full snapshot
Posted by Arjun Mishra via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71039/#review216451
-----------------------------------------------------------
Ship it!
Ship It!
- Arjun Mishra
On July 9, 2019, 3 p.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71039/
> -----------------------------------------------------------
>
> (Updated July 9, 2019, 3 p.m.)
>
>
> Review request for sentry and kalyan kumar kalvagadda.
>
>
> Bugs: SENTRY-2528
> https://issues.apache.org/jira/browse/SENTRY-2528
>
>
> Repository: sentry
>
>
> Description
> -------
>
> When fetching a full snapshot we get the below error. This is a regression of SENTRY-2301
>
> 2019-07-07 23:07:39,677 ERROR org.apache.sentry.service.thrift.SentryHMSClient: Snapshot created failed
> java.util.IllegalFormatConversionException: f != java.lang.Long
> at java.util.Formatter$FormatSpecifier.failConversion(Formatter.java:4302)
> at java.util.Formatter$FormatSpecifier.printFloat(Formatter.java:2806)
> at java.util.Formatter$FormatSpecifier.print(Formatter.java:2753)
> at java.util.Formatter.format(Formatter.java:2520)
> at java.util.Formatter.format(Formatter.java:2455)
> at java.lang.String.format(String.java:2940)
> at org.apache.sentry.service.thrift.FullUpdateInitializer.getFullHMSSnapshot(FullUpdateInitializer.java:552)
> at org.apache.sentry.service.thrift.SentryHMSClient.fetchFullUpdate(SentryHMSClient.java:244)
> at org.apache.sentry.service.thrift.SentryHMSClient.getFullSnapshot(SentryHMSClient.java:147)
> at org.apache.sentry.provider.db.service.persistent.HMSFollower.createFullSnapshot(HMSFollower.java:409)
> at org.apache.sentry.provider.db.service.persistent.HMSFollower.syncupWithHms(HMSFollower.java:237)
> at org.apache.sentry.provider.db.service.persistent.HMSFollower.run(HMSFollower.java:198)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java d4bca42faea51d87164568c23bd7849c56450f32
>
>
> Diff: https://reviews.apache.org/r/71039/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Mishra
>
>