You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "len548 (via GitHub)" <gi...@apache.org> on 2026/08/13 11:33:35 UTC

[PR] HDDS-16163. Fix TrashOzoneFileSystem error handling on LEGACY buckets [ozone]

len548 opened a new pull request, #11016:
URL: https://github.com/apache/ozone/pull/11016

   ## What changes were proposed in this pull request?
   On legacy buckets (non-FSO path), `delete()` and `rename()` in `TrashOzoneFileSystem` could report success even when the underlying OM write failed:
   
   1. `RenameIterator` / `DeleteIterator` swallowed errors — `submitRequest()` failures were caught, logged, and iteration continued as if nothing failed.
   2. Return values were ignored — top-level `delete()` / `rename()` always returned true, even when `iterate()` returned false.
   3. Null OMRequest was not handled — if `createOMRequest()` failed, a null request could be passed to `submitRequest()` or fail without propagating failure to the caller.
   
   This fix propagates these delete/rename failures from the LEGACY trash iterator path instead of always returning true.
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-16163
   
   ## How was this patch tested?
   Add UT written by Cursor with Composer 2.5 model


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-16163. Fix TrashOzoneFileSystem error handling on LEGACY buckets [ozone]

Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on PR #11016:
URL: https://github.com/apache/ozone/pull/11016#issuecomment-5325673864

   @len548  Looks like there are merge conflicts. could you please resolve them?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-16163. Fix TrashOzoneFileSystem error handling on LEGACY buckets [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #11016:
URL: https://github.com/apache/ozone/pull/11016


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-16163. Fix TrashOzoneFileSystem error handling on LEGACY buckets [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #11016:
URL: https://github.com/apache/ozone/pull/11016#issuecomment-5444080868

   Thanks @len548 for the patch, @sadanand48 for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-16163. Fix TrashOzoneFileSystem error handling on LEGACY buckets [ozone]

Posted by "len548 (via GitHub)" <gi...@apache.org>.
len548 commented on PR #11016:
URL: https://github.com/apache/ozone/pull/11016#issuecomment-5340065606

   Thank you @sadanand48 for pointing out the merge conflict. I kept `TestTrashOzoneFileSystem` from master unchanged and renamed one in this PR to `TestTrashOzoneFileSystemLegacyBucket`, since the two suites use different configs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org