You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/08/08 13:31:37 UTC

[GitHub] [buildstream] wsalmonct commented on a diff in pull request #1707: Cache full build tree for debugging failed builds

wsalmonct commented on code in PR #1707:
URL: https://github.com/apache/buildstream/pull/1707#discussion_r940244918


##########
src/buildstream/_artifact.py:
##########
@@ -52,7 +52,7 @@
 #
 class Artifact:
 
-    version = 1
+    version = 2

Review Comment:
   I had assumed that this value would match the version in src/buildstream/_protos/buildstream/v2/artifact.proto which clams to only need bumping when mandatory fields change.. are these in fact unrelated? or should the other be bumped also?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org