You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/18 09:25:19 UTC
[GitHub] [arrow] Ulimo opened a new pull request #8702: [ARROW-10634][C#][CI] Change the build version from 2.2 to 3.1 in CI
Ulimo opened a new pull request #8702:
URL: https://github.com/apache/arrow/pull/8702
Upgraded build version to 3.1 and C# version to 8.
Also added EmbedUntrackedSources so auto generated code will work with sourcelink.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] eerhardt closed pull request #8702: ARROW-10634: [C#][CI] Change the build version from 2.2 to 3.1 in CI
Posted by GitBox <gi...@apache.org>.
eerhardt closed pull request #8702:
URL: https://github.com/apache/arrow/pull/8702
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8702: [ARROW-10634][C#][CI] Change the build version from 2.2 to 3.1 in CI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8702:
URL: https://github.com/apache/arrow/pull/8702#issuecomment-729554537
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] eerhardt commented on pull request #8702: ARROW-10634: [C#][CI] Change the build version from 2.2 to 3.1 in CI
Posted by GitBox <gi...@apache.org>.
eerhardt commented on pull request #8702:
URL: https://github.com/apache/arrow/pull/8702#issuecomment-730629122
> should FluentBuilderExample.csproj also be updated to 3.1?
No, it doesn't build as part of CI. Let's just leave it for now. Maybe in the future we could add it as a unit test so it is protected against getting broken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8702: ARROW-10634: [C#][CI] Change the build version from 2.2 to 3.1 in CI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8702:
URL: https://github.com/apache/arrow/pull/8702#issuecomment-729562831
https://issues.apache.org/jira/browse/ARROW-10634
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Ulimo commented on pull request #8702: ARROW-10634: [C#][CI] Change the build version from 2.2 to 3.1 in CI
Posted by GitBox <gi...@apache.org>.
Ulimo commented on pull request #8702:
URL: https://github.com/apache/arrow/pull/8702#issuecomment-730616626
@eerhardt sorry for pinging, notifying atleast that I added this PR, I understand that you are probably super busy, so mostly wondering when/if this can be reviewed? Or is there someone else in the csharp community for arrow that can review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Ulimo commented on pull request #8702: ARROW-10634: [C#][CI] Change the build version from 2.2 to 3.1 in CI
Posted by GitBox <gi...@apache.org>.
Ulimo commented on pull request #8702:
URL: https://github.com/apache/arrow/pull/8702#issuecomment-729559868
I did not change the version under examples, should FluentBuilderExample.csproj also be updated to 3.1?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org