[GitHub] [iceberg] kbendick commented on a change in pull request #1526: [MINOR] Switch to FileIO for InputFormat

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #1526:
URL: https://github.com/apache/iceberg/pull/1526#discussion_r498505271



##########
File path: mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java
##########
@@ -165,13 +166,15 @@ private static void checkResiduals(CombinedScanTask task) {
     private Iterator<FileScanTask> tasks;
     private T currentRow;
     private CloseableIterator<T> currentIterator;
+    private FileIO fileIO;
 
     @Override
     public void initialize(InputSplit split, TaskAttemptContext newContext) {
       Configuration conf = newContext.getConfiguration();
       // For now IcebergInputFormat does its own split planning and does not accept FileSplit instances
       CombinedScanTask task = ((IcebergSplit) split).task();
       this.context = newContext;
+      this.fileIO = new HadoopFileIO(this.context.getConfiguration());

Review comment:
       Good to know! Do we document these style preferences anywhere (using `this`, when we use the term `project` vs `select`, etc)? @rdblue 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org