You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/04 02:43:02 UTC
[GitHub] [pulsar] codelipenghui opened a new issue #7161: Fix problems with managed-ledger properties.
codelipenghui opened a new issue #7161:
URL: https://github.com/apache/pulsar/issues/7161
### Fix problems with managed-ledger properties.
- It's not checking that there no other metadata operations in place. That will result in ZK bad version errors.
- It's writing the metadata without updating the in-memory version that the managed ledger keeps. This will result in a managed ledger fenced error each time a property is set, forcing the topic to get closed.
- Why do we need to re-read the metadata from store? We already have that metadata and its corresponding version in memory.
- Finally, from the API is not clear what happens if there are already some properties and I just want to add a new one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on issue #7161: Fix problems with managed-ledger properties.
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on issue #7161:
URL: https://github.com/apache/pulsar/issues/7161#issuecomment-638569009
I will fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui closed issue #7161: Fix problems with managed-ledger properties.
Posted by GitBox <gi...@apache.org>.
codelipenghui closed issue #7161:
URL: https://github.com/apache/pulsar/issues/7161
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on issue #7161: Fix problems with managed-ledger properties.
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #7161:
URL: https://github.com/apache/pulsar/issues/7161#issuecomment-639216664
Thanks @zhanghaou for the help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyuanpeng commented on issue #7161: Fix problems with managed-ledger properties.
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on issue #7161:
URL: https://github.com/apache/pulsar/issues/7161#issuecomment-660642582
What's the status of this issue? look like finished.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zongtanghu edited a comment on issue #7161: Fix problems with managed-ledger properties.
Posted by GitBox <gi...@apache.org>.
zongtanghu edited a comment on issue #7161:
URL: https://github.com/apache/pulsar/issues/7161#issuecomment-647139470
The problem 2 and 3 you said, you put forward other two issues maybe better? @zhanghaou
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on issue #7161: Fix problems with managed-ledger properties.
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on issue #7161:
URL: https://github.com/apache/pulsar/issues/7161#issuecomment-641178177
I have solved the Problem1 and 4 in the PR[https://github.com/apache/pulsar/pull/7222](https://github.com/apache/pulsar/pull/7222), please take a look.
Problem 2：
The in-memory version of propertiesMap is updated by callback of store.asyncUpdateLedgerIds, is there something wrong with my understanding?
Problem 3：
Re-read the metadata from store is used when the managedLedger is reloaded and we need to reset the propertiesMap in memory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on issue #7161: Fix problems with managed-ledger properties.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #7161:
URL: https://github.com/apache/pulsar/issues/7161#issuecomment-660745846
@liangyuanpeng This issue is fixed by #7357
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zongtanghu commented on issue #7161: Fix problems with managed-ledger properties.
Posted by GitBox <gi...@apache.org>.
zongtanghu commented on issue #7161:
URL: https://github.com/apache/pulsar/issues/7161#issuecomment-647139470
The problem 2 and 3 you said, you put forward other two issues maybe better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org