[GitHub] [orc] deshanxiao commented on a diff in pull request #1278: ORC-1289: Refine DynamicArray

[GitBox <gi...@apache.org>]

deshanxiao commented on code in PR #1278:
URL: https://github.com/apache/orc/pull/1278#discussion_r997662396


##########
java/core/src/java/org/apache/orc/impl/DynamicByteArray.java:
##########
@@ -122,29 +121,6 @@ public int add(byte[] value, int valueOffset, int valueLength) {
     return result;
   }
 
-  /**
-   * Read the entire stream into this array.
-   * @param in the stream to read from
-   * @throws IOException
-   */
-  public void readAll(InputStream in) throws IOException {
-    int currentChunk = length / chunkSize;
-    int currentOffset = length % chunkSize;
-    grow(currentChunk);
-    int currentLength = in.read(data[currentChunk], currentOffset,
-      chunkSize - currentOffset);
-    while (currentLength > 0) {
-      length += currentLength;
-      currentOffset = length % chunkSize;
-      if (currentOffset == 0) {
-        currentChunk = length / chunkSize;
-        grow(currentChunk);
-      }
-      currentLength = in.read(data[currentChunk], currentOffset,
-        chunkSize - currentOffset);
-    }
-  }
-

Review Comment:
   Sorry, will remove it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org