You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "guohao-rosicky (via GitHub)" <gi...@apache.org> on 2023/05/26 06:22:56 UTC
[GitHub] [ozone] guohao-rosicky opened a new pull request, #4780: HDDS-8696. Ozone Streaming support BlockToken
guohao-rosicky opened a new pull request, #4780:
URL: https://github.com/apache/ozone/pull/4780
## What changes were proposed in this pull request?
HDDS-8696. Ozone Streaming support BlockToken
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8696
## How was this patch tested?
https://github.com/guohao-rosicky/ozone/actions/runs/5077889238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #4780: HDDS-8696. Ozone Streaming support BlockToken
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4780:
URL: https://github.com/apache/ozone/pull/4780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4780: HDDS-8696. Ozone Streaming support BlockToken
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4780:
URL: https://github.com/apache/ozone/pull/4780#issuecomment-1578963620
Thanks @guohao-rosicky for the patch, @duongkame for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] duongkame commented on a diff in pull request #4780: HDDS-8696. Ozone Streaming support BlockToken
Posted by "duongkame (via GitHub)" <gi...@apache.org>.
duongkame commented on code in PR #4780:
URL: https://github.com/apache/ozone/pull/4780#discussion_r1210966331
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockDataStreamOutput.java:
##########
@@ -205,6 +205,10 @@ private DataStreamOutput setupStream(Pipeline pipeline) throws IOException {
.setContainerID(blockID.get().getContainerID())
.setDatanodeUuid(id).setWriteChunk(writeChunkRequest);
+ if (token != null) {
+ builder.setEncodedToken(token.encodeToUrlString());
Review Comment:
nit: shall we add any test for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org