You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/23 19:54:39 UTC

[GitHub] [arrow] ianmcook commented on pull request #10585: ARROW-12016 [C++] Implement array_sort_indices and sort_indices for BOOL type

ianmcook commented on pull request #10585:
URL: https://github.com/apache/arrow/pull/10585#issuecomment-867115679


   @nirandaperera as part of this PR, could you please make two small changes to the R package tests to exercise this new capability?
   
   1. Remove the comment at the end of this line:
   https://github.com/apache/arrow/blob/515b05c3bbad66a60b7c2577c50f7a258219add8/r/tests/testthat/helper-data.R#L155
   
   2. Remove this line:
   https://github.com/apache/arrow/blob/450e0eb7a640881788f839d0a475d796fa23c81c/r/tests/testthat/test-dplyr-arrange.R#L162
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org