[GitHub] [mynewt-core] mkiiskila commented on issue #1679: sys/config: commit for all fcbs together only once

[GitBox <gi...@apache.org>]

mkiiskila commented on issue #1679: sys/config: commit for all fcbs together only once
URL: https://github.com/apache/mynewt-core/pull/1679#issuecomment-470402599
 
 
   No, this is not ok, and would cause issues. Here is what this would specifically break:
   
   We currently can load manufacturing config from one config source, and runtime config from another.
   And we can have a config variable which says whether user/app config will be stored on config save.
   
   Thinking is that you start in manufacturing mode, with no config present. Then you enter serial number, per devices keys etc. Stuff you cannot change at runtime, but need to configure at factory. Then, as the last thing, you set a config variable saying 'not in manufacturing mode'.
   
   Select config handlers then check this variable before accepting new config values.
   Manufacturing mode is exited at commit handler. Not when config value is set, but at commit time. 
   This because the order in which config variables are loaded from a source is not deterministic. And can even change, thanks to compression.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services