[GitHub] [iceberg] rdblue commented on a change in pull request #2114: Spark: Replace spec.fields().isEmpty() to isUnpartitioned()

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2114:
URL: https://github.com/apache/iceberg/pull/2114#discussion_r560501016



##########
File path: spark/src/main/java/org/apache/iceberg/spark/source/RowDataRewriter.java
##########
@@ -103,8 +103,8 @@ public RowDataRewriter(Table table, PartitionSpec spec, boolean caseSensitive,
     OutputFileFactory fileFactory = new OutputFileFactory(
         spec, format, locations, io.value(), encryptionManager.value(), partitionId, taskId);
 
-    TaskWriter<InternalRow> writer;
-    if (spec.fields().isEmpty()) {
+    final TaskWriter<InternalRow> writer;

Review comment:
       We use `final` because it is unlikely that this actually helps. In Java 8, final detection is quite good, which is why non-final variables can be used in closures and lambdas. And final doesn't produce different byte code so it can't do much to help at runtime.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org