[jira] [Comment Edited] (SOLR-14115) Deprecate zkcli and bin/solr zk support

["Erick Erickson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-14115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16999509#comment-16999509 ] 

Erick Erickson edited comment on SOLR-14115 at 12/18/19 10:41 PM:
------------------------------------------------------------------

I won't argue too hard to remove "bin/solr zl *", I'm glad people find it useful. Certainly I've used it to fix up ZK nodes in emergency situations.

If there were a good UI for editing Zookeeper, I'd advocate more strongly to remove "bin/solr zk *", but I don't find one on a quick search. I see several UI editors, but I don't have any confidence that they'll be maintained long-term.


was (Author: erickerickson):
I won't argue too hard to remove bin/solr, I'm glad people find it useful. Certainly I've used it to fix up ZK nodes in emergency situations.

If there were a good UI for editing Zookeeper, I'd advocate more strongly to remove bin/solr, but I don't find one on a quick search. I see several UI editors, but I don't have any confidence that they'll be maintained long-term.

> Deprecate zkcli and bin/solr zk support
> ---------------------------------------
>
>                 Key: SOLR-14115
>                 URL: https://issues.apache.org/jira/browse/SOLR-14115
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: scripts and tools
>            Reporter: Erick Erickson
>            Priority: Major
>
> I think it's a valid argument that these have outlived their usefulness and we should remove them and have APIs to do what Solr requires. Especially if we can find and point to a third-party visual ZK tool for _changing_ arbitrary data in ZK. Zookeeper 3.5.5 has the admin server which has a UI (although I don't see how to change data in ZK with it. Haven't looked very much).
> While we're ripping stuff out of Solr, are these candidates? It would break my heart to rip ZK support out from bin/solr, but all good things must come to an end. Why do we maintain three (zkcli, bin/solr and the APIs) ways of doing the same thing?
> Mark put the zkcli stuff in before we had APIs to do what Solr needs to do with ZK, mainly uploading configsets at the time. I put the zk support in bin/solr also before the APIs existed because I thought having to learn our custom wrapper for ZK was yet another orphan bit of code laying around. All before we had things like the configsets API.
> Personally, I'd prefer removing zkcli rather than bin/solr, but that's because I originated the bin/solr code ;)
> This occurred when reading SOLR-14109, I'm not entirely sure what I _really_ think about it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org