You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/08/06 17:52:17 UTC
[GitHub] [incubator-pekko] pjfanning opened a new pull request, #545: Yet more Akka version numbers in deprecation warnings
pjfanning opened a new pull request, #545:
URL: https://github.com/apache/incubator-pekko/pull/545
more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning merged pull request #545: Yet more Akka version numbers in deprecation warnings
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #545:
URL: https://github.com/apache/incubator-pekko/pull/545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #545: Yet more Akka version numbers in deprecation warnings
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #545:
URL: https://github.com/apache/incubator-pekko/pull/545#discussion_r1285257076
##########
actor/src/main/scala/org/apache/pekko/dispatch/Mailboxes.scala:
##########
@@ -169,7 +169,7 @@ private[pekko] class Mailboxes(
dispatcherConfig.hasPath("mailbox-type") &&
dispatcherConfig.getString("mailbox-type") != Deploy.NoMailboxGiven
- // TODO remove in 2.3
+ // TODO remove in Akka 2.3
Review Comment:
I think that fine, will do several rounds of cleaning in 1.1.x。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #545: Yet more Akka version numbers in deprecation warnings
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #545:
URL: https://github.com/apache/incubator-pekko/pull/545#discussion_r1285259670
##########
actor/src/main/scala/org/apache/pekko/dispatch/Mailboxes.scala:
##########
@@ -169,7 +169,7 @@ private[pekko] class Mailboxes(
dispatcherConfig.hasPath("mailbox-type") &&
dispatcherConfig.getString("mailbox-type") != Deploy.NoMailboxGiven
- // TODO remove in 2.3
+ // TODO remove in Akka 2.3
Review Comment:
when we agree what Pekko versions to remove things in, we can change this - before to leave the '2.3' text there is confusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #545: Yet more Akka version numbers in deprecation warnings
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #545:
URL: https://github.com/apache/incubator-pekko/pull/545#discussion_r1285252362
##########
actor/src/main/scala/org/apache/pekko/dispatch/Mailboxes.scala:
##########
@@ -169,7 +169,7 @@ private[pekko] class Mailboxes(
dispatcherConfig.hasPath("mailbox-type") &&
dispatcherConfig.getString("mailbox-type") != Deploy.NoMailboxGiven
- // TODO remove in 2.3
+ // TODO remove in Akka 2.3
Review Comment:
This comment should be rephrased, this project is no longer Akka
##########
cluster/src/main/scala/org/apache/pekko/cluster/protobuf/ClusterMessageSerializer.scala:
##########
@@ -57,7 +57,7 @@ private[pekko] object ClusterMessageSerializer {
val OldGossipEnvelopeManifest = "org.apache.pekko.cluster.GossipEnvelope"
val OldClusterRouterPoolManifest = "org.apache.pekko.cluster.routing.ClusterRouterPool"
- // is handled on the deserializing side in 2.6.2 and then on the serializing side in 2.6.3
+ // is handled on the deserializing side in Akka 2.6.2 and then on the serializing side in Akka 2.6.3
Review Comment:
I think you can just remove this comment, it's no longer relevant since Pekko is new project
##########
persistence/src/main/java/org/apache/pekko/persistence/serialization/MessageFormats.java:
##########
@@ -1616,11 +1616,11 @@ public Builder clearSender() {
}
/**
* <pre>
- * optional int32 redeliveries = 6; // Removed in 2.4
- * repeated string confirms = 7; // Removed in 2.4
- * optional bool confirmable = 8; // Removed in 2.4
- * optional DeliveredMessage confirmMessage = 9; // Removed in 2.4
- * optional string confirmTarget = 10; // Removed in 2.4
+ * optional int32 redeliveries = 6; // Removed in Akka 2.4
Review Comment:
We can probably delete these comments entirely
##########
cluster/src/test/scala/org/apache/pekko/cluster/protobuf/ClusterMessageSerializerSpec.scala:
##########
@@ -131,7 +131,7 @@ class ClusterMessageSerializerSpec extends PekkoSpec("pekko.actor.provider = clu
checkSerialization(InternalClusterAction.Welcome(uniqueAddress, g2))
}
- // can be removed in 2.6.3 only checks deserialization with new not yet in effect manifests for 2.6.2
+ // can be removed in Akka 2.6.3 only checks deserialization with new not yet in effect manifests for Akka 2.6.2
Review Comment:
Should rephrase comment, i.e. remove in Pekko 1.2.0???
##########
cluster/src/main/scala/org/apache/pekko/cluster/protobuf/ClusterMessageSerializer.scala:
##########
@@ -139,7 +139,7 @@ final class ClusterMessageSerializer(val system: ExtendedActorSystem)
case DownManifest => deserializeDown(bytes)
case ExitingConfirmedManifest => deserializeExitingConfirmed(bytes)
case ClusterRouterPoolManifest => deserializeClusterRouterPool(bytes)
- // needs to stay in 2.6.5 to be able to talk to a 2.5.{3,4} node during rolling upgrade
+ // needs to stay in Akka 2.6.5 to be able to talk to a 2.5.{3,4} node during rolling upgrade
Review Comment:
Likewise I think this comment can be removed since its no longer relevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #545: Yet more Akka version numbers in deprecation warnings
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #545:
URL: https://github.com/apache/incubator-pekko/pull/545#discussion_r1285258848
##########
cluster/src/test/scala/org/apache/pekko/cluster/protobuf/ClusterMessageSerializerSpec.scala:
##########
@@ -131,7 +131,7 @@ class ClusterMessageSerializerSpec extends PekkoSpec("pekko.actor.provider = clu
checkSerialization(InternalClusterAction.Welcome(uniqueAddress, g2))
}
- // can be removed in 2.6.3 only checks deserialization with new not yet in effect manifests for 2.6.2
+ // can be removed in Akka 2.6.3 only checks deserialization with new not yet in effect manifests for Akka 2.6.2
Review Comment:
My preference is to start by making the confusing version numbers explicit. There will be arguments about what Pekko versions will be the ones where we can remove code. There is an incomplete discussion on the mailing list. When we start making some decisions, we can go back into the code and replace the Akka versions with the agreed Pekko versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #545: Yet more Akka version numbers in deprecation warnings
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #545:
URL: https://github.com/apache/incubator-pekko/pull/545#discussion_r1285259815
##########
persistence/src/main/java/org/apache/pekko/persistence/serialization/MessageFormats.java:
##########
@@ -1616,11 +1616,11 @@ public Builder clearSender() {
}
/**
* <pre>
- * optional int32 redeliveries = 6; // Removed in 2.4
- * repeated string confirms = 7; // Removed in 2.4
- * optional bool confirmable = 8; // Removed in 2.4
- * optional DeliveredMessage confirmMessage = 9; // Removed in 2.4
- * optional string confirmTarget = 10; // Removed in 2.4
+ * optional int32 redeliveries = 6; // Removed in Akka 2.4
Review Comment:
I've removed those `<pre>` blocks now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #545: Yet more Akka version numbers in deprecation warnings
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #545:
URL: https://github.com/apache/incubator-pekko/pull/545#issuecomment-1666956955
I think this is fine to get merged and backported to 1.0.x
And then do the cleaning up in 1.1.x，the versions record help sometime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org