You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "deniskuzZ (via GitHub)" <gi...@apache.org> on 2026/10/15 19:03:04 UTC
[PR] HIVE-30182: Parquet: a leaf without its runtime value drops the whole row-group filter [hive]
deniskuzZ opened a new pull request, #6882:
URL: https://github.com/apache/hive/pull/6882
### What changes were proposed in this pull request?
In `ParquetFilterPredicateConverter`, a leaf whose runtime value (`DynamicValue`) is not available filters nothing (returns `null`) instead of failing the whole conversion.
### Why are the changes needed?
One such leaf made `toFilterPredicate` return `null`, so the reader lost the static leaves of the same conjunction too, and each failure logged an ERROR with a stack trace: `BETWEEN`/`IN` got an empty literal list ("Not able to build 'between' operation filter with [] which needs two literals"), a single literal threw `NoDynamicValuesException`. One TPC-DS 10 TB run logged 45,927 of these from the LLAP IO threads reading semijoin-filtered Parquet scans. The search argument pushes `NOT` down to the leaves, so dropping a leaf from a conjunction only weakens the filter; a disjunction containing it still filters nothing.
### Does this PR introduce _any_ user-facing change?
No; Parquet scans keep the row-group filtering of their other conjuncts, and the ERROR log lines are gone.
### How was this patch tested?
`TestParquetFilterPredicate#testUnresolvedRuntimeValueDropsOnlyItsLeaf`: `a < 5 AND b = <unavailable> AND c BETWEEN <unavailable>` converts to `lt(a, 5)` (was `null`); `a < 5 OR c BETWEEN <unavailable>` stays `null`. `TestParquetRowGroupFilter` and `TestConvertAstToSearchArg` pass.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-30182: Parquet: a leaf without its runtime value drops the whole row-group filter [hive]
Posted by "abstractdog (via GitHub) via gitbox" <gi...@hive.apache.org>.
abstractdog commented on PR #6882:
URL: https://github.com/apache/hive/pull/6882#issuecomment-6766311225
superceded by https://github.com/apache/hive/pull/6954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-30182: Parquet: a leaf without its runtime value drops the whole row-group filter [hive]
Posted by "abstractdog (via GitHub) via gitbox" <gi...@hive.apache.org>.
abstractdog closed pull request #6882: HIVE-30182: Parquet: a leaf without its runtime value drops the whole row-group filter
URL: https://github.com/apache/hive/pull/6882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-30182: Parquet: a leaf without its runtime value drops the whole row-group filter [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6882:
URL: https://github.com/apache/hive/pull/6882#issuecomment-6201565466
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6882) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6882&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6882&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6882&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6882&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6882&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6882)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org