You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2019/07/05 16:56:06 UTC

[commons-collections] branch master updated: Remove: Unnecessary @SuppressWarnings("unchecked").

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-collections.git


The following commit(s) were added to refs/heads/master by this push:
     new a434957  Remove: Unnecessary @SuppressWarnings("unchecked").
a434957 is described below

commit a434957f70fcce4e4c853240d8db64d2fbf22867
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Jul 5 12:56:01 2019 -0400

    Remove: Unnecessary @SuppressWarnings("unchecked").
---
 .../org/apache/commons/collections4/functors/ChainedTransformer.java     | 1 -
 .../java/org/apache/commons/collections4/functors/CloneTransformer.java  | 1 -
 .../java/org/apache/commons/collections4/functors/ConstantFactory.java   | 1 -
 .../org/apache/commons/collections4/functors/ConstantTransformer.java    | 1 -
 .../java/org/apache/commons/collections4/functors/DefaultEquator.java    | 1 -
 .../java/org/apache/commons/collections4/functors/ExceptionClosure.java  | 1 -
 .../java/org/apache/commons/collections4/functors/ExceptionFactory.java  | 1 -
 .../org/apache/commons/collections4/functors/ExceptionPredicate.java     | 1 -
 .../org/apache/commons/collections4/functors/ExceptionTransformer.java   | 1 -
 .../java/org/apache/commons/collections4/functors/FalsePredicate.java    | 1 -
 .../org/apache/commons/collections4/functors/InstantiateTransformer.java | 1 -
 src/main/java/org/apache/commons/collections4/functors/NOPClosure.java   | 1 -
 .../java/org/apache/commons/collections4/functors/NOPTransformer.java    | 1 -
 .../java/org/apache/commons/collections4/functors/NotNullPredicate.java  | 1 -
 .../java/org/apache/commons/collections4/functors/NullPredicate.java     | 1 -
 .../java/org/apache/commons/collections4/functors/TruePredicate.java     | 1 -
 16 files changed, 16 deletions(-)

diff --git a/src/main/java/org/apache/commons/collections4/functors/ChainedTransformer.java b/src/main/java/org/apache/commons/collections4/functors/ChainedTransformer.java
index 65ba8a7..0d0aac5 100644
--- a/src/main/java/org/apache/commons/collections4/functors/ChainedTransformer.java
+++ b/src/main/java/org/apache/commons/collections4/functors/ChainedTransformer.java
@@ -66,7 +66,6 @@ public class ChainedTransformer<T> implements Transformer<T, T>, Serializable {
      * @throws NullPointerException if the transformers collection is null
      * @throws NullPointerException if any transformer in the collection is null
      */
-    @SuppressWarnings("unchecked")
     public static <T> Transformer<T, T> chainedTransformer(
             final Collection<? extends Transformer<? super T, ? extends T>> transformers) {
         if (transformers == null) {
diff --git a/src/main/java/org/apache/commons/collections4/functors/CloneTransformer.java b/src/main/java/org/apache/commons/collections4/functors/CloneTransformer.java
index 37feec3..a01eba0 100644
--- a/src/main/java/org/apache/commons/collections4/functors/CloneTransformer.java
+++ b/src/main/java/org/apache/commons/collections4/functors/CloneTransformer.java
@@ -45,7 +45,6 @@ public class CloneTransformer<T> implements Transformer<T, T> {
      * @return the singleton instance
      * @since 3.1
      */
-    @SuppressWarnings("unchecked") // the singleton instance works for all types
     public static <T> Transformer<T, T> cloneTransformer() {
         return INSTANCE;
     }
diff --git a/src/main/java/org/apache/commons/collections4/functors/ConstantFactory.java b/src/main/java/org/apache/commons/collections4/functors/ConstantFactory.java
index dbd3ddd..b915ee4 100644
--- a/src/main/java/org/apache/commons/collections4/functors/ConstantFactory.java
+++ b/src/main/java/org/apache/commons/collections4/functors/ConstantFactory.java
@@ -49,7 +49,6 @@ public class ConstantFactory<T> implements Factory<T>, Serializable {
      * @param constantToReturn  the constant object to return each time in the factory
      * @return the <code>constant</code> factory.
      */
-    @SuppressWarnings("unchecked") // The null factory works for all object types
     public static <T> Factory<T> constantFactory(final T constantToReturn) {
         if (constantToReturn == null) {
             return NULL_INSTANCE;
diff --git a/src/main/java/org/apache/commons/collections4/functors/ConstantTransformer.java b/src/main/java/org/apache/commons/collections4/functors/ConstantTransformer.java
index 3fb5f33..dd33e47 100644
--- a/src/main/java/org/apache/commons/collections4/functors/ConstantTransformer.java
+++ b/src/main/java/org/apache/commons/collections4/functors/ConstantTransformer.java
@@ -49,7 +49,6 @@ public class ConstantTransformer<I, O> implements Transformer<I, O>, Serializabl
      * @param <O>  the output type
      * @return Transformer&lt;I, O&gt; that always returns null.
      */
-    @SuppressWarnings("unchecked") // The null transformer works for all object types
     public static <I, O> Transformer<I, O> nullTransformer() {
         return NULL_INSTANCE;
     }
diff --git a/src/main/java/org/apache/commons/collections4/functors/DefaultEquator.java b/src/main/java/org/apache/commons/collections4/functors/DefaultEquator.java
index 36c116d..c2d719d 100644
--- a/src/main/java/org/apache/commons/collections4/functors/DefaultEquator.java
+++ b/src/main/java/org/apache/commons/collections4/functors/DefaultEquator.java
@@ -46,7 +46,6 @@ public class DefaultEquator<T> implements Equator<T>, Serializable {
      * @param <T>  the object type
      * @return the singleton instance
      */
-    @SuppressWarnings("unchecked") // the static instance works for all types
     public static <T> DefaultEquator<T> defaultEquator() {
         return DefaultEquator.INSTANCE;
     }
diff --git a/src/main/java/org/apache/commons/collections4/functors/ExceptionClosure.java b/src/main/java/org/apache/commons/collections4/functors/ExceptionClosure.java
index ce6843e..3ccc968 100644
--- a/src/main/java/org/apache/commons/collections4/functors/ExceptionClosure.java
+++ b/src/main/java/org/apache/commons/collections4/functors/ExceptionClosure.java
@@ -42,7 +42,6 @@ public final class ExceptionClosure<E> implements Closure<E>, Serializable {
      * @return the singleton instance
      * @since 3.1
      */
-    @SuppressWarnings("unchecked")  // the static instance works for all types
     public static <E> Closure<E> exceptionClosure() {
         return INSTANCE;
     }
diff --git a/src/main/java/org/apache/commons/collections4/functors/ExceptionFactory.java b/src/main/java/org/apache/commons/collections4/functors/ExceptionFactory.java
index a40b553..0d9d83f 100644
--- a/src/main/java/org/apache/commons/collections4/functors/ExceptionFactory.java
+++ b/src/main/java/org/apache/commons/collections4/functors/ExceptionFactory.java
@@ -42,7 +42,6 @@ public final class ExceptionFactory<T> implements Factory<T>, Serializable {
      * @return the singleton instance
      * @since 3.1
      */
-    @SuppressWarnings("unchecked") // the static instance works for all types
     public static <T> Factory<T> exceptionFactory() {
         return INSTANCE;
     }
diff --git a/src/main/java/org/apache/commons/collections4/functors/ExceptionPredicate.java b/src/main/java/org/apache/commons/collections4/functors/ExceptionPredicate.java
index 6d8f2aa..9eacefd 100644
--- a/src/main/java/org/apache/commons/collections4/functors/ExceptionPredicate.java
+++ b/src/main/java/org/apache/commons/collections4/functors/ExceptionPredicate.java
@@ -42,7 +42,6 @@ public final class ExceptionPredicate<T> implements Predicate<T>, Serializable {
      * @return the singleton instance
      * @since 3.1
      */
-    @SuppressWarnings("unchecked") // the static instance works for all types
     public static <T> Predicate<T> exceptionPredicate() {
         return INSTANCE;
     }
diff --git a/src/main/java/org/apache/commons/collections4/functors/ExceptionTransformer.java b/src/main/java/org/apache/commons/collections4/functors/ExceptionTransformer.java
index 3626fb9..3412365 100644
--- a/src/main/java/org/apache/commons/collections4/functors/ExceptionTransformer.java
+++ b/src/main/java/org/apache/commons/collections4/functors/ExceptionTransformer.java
@@ -43,7 +43,6 @@ public final class ExceptionTransformer<I, O> implements Transformer<I, O>, Seri
      * @return the singleton instance
      * @since 3.1
      */
-    @SuppressWarnings("unchecked") // the static instance works for all types
     public static <I, O> Transformer<I, O> exceptionTransformer() {
         return INSTANCE;
     }
diff --git a/src/main/java/org/apache/commons/collections4/functors/FalsePredicate.java b/src/main/java/org/apache/commons/collections4/functors/FalsePredicate.java
index f88f018..f3dd7e1 100644
--- a/src/main/java/org/apache/commons/collections4/functors/FalsePredicate.java
+++ b/src/main/java/org/apache/commons/collections4/functors/FalsePredicate.java
@@ -41,7 +41,6 @@ public final class FalsePredicate<T> implements Predicate<T>, Serializable {
      * @return the singleton instance
      * @since 4.0
      */
-    @SuppressWarnings("unchecked") // the static instance works for all types
     public static <T> Predicate<T> falsePredicate() {
         return INSTANCE;
     }
diff --git a/src/main/java/org/apache/commons/collections4/functors/InstantiateTransformer.java b/src/main/java/org/apache/commons/collections4/functors/InstantiateTransformer.java
index e8c624b..7ae7246 100644
--- a/src/main/java/org/apache/commons/collections4/functors/InstantiateTransformer.java
+++ b/src/main/java/org/apache/commons/collections4/functors/InstantiateTransformer.java
@@ -50,7 +50,6 @@ public class InstantiateTransformer<T> implements Transformer<Class<? extends T>
      * @param <T>  the type of the objects to be created
      * @return Transformer&lt;Class&lt;? extends T&gt;, T&gt;
      */
-    @SuppressWarnings("unchecked")
     public static <T> Transformer<Class<? extends T>, T> instantiateTransformer() {
         return NO_ARG_INSTANCE;
     }
diff --git a/src/main/java/org/apache/commons/collections4/functors/NOPClosure.java b/src/main/java/org/apache/commons/collections4/functors/NOPClosure.java
index 1ec9d15..6bc4e2a 100644
--- a/src/main/java/org/apache/commons/collections4/functors/NOPClosure.java
+++ b/src/main/java/org/apache/commons/collections4/functors/NOPClosure.java
@@ -41,7 +41,6 @@ public final class NOPClosure<E> implements Closure<E>, Serializable {
      * @return the singleton instance
      * @since 3.1
      */
-    @SuppressWarnings("unchecked")
     public static <E> Closure<E> nopClosure() {
         return INSTANCE;
     }
diff --git a/src/main/java/org/apache/commons/collections4/functors/NOPTransformer.java b/src/main/java/org/apache/commons/collections4/functors/NOPTransformer.java
index 439902d..4b23ded 100644
--- a/src/main/java/org/apache/commons/collections4/functors/NOPTransformer.java
+++ b/src/main/java/org/apache/commons/collections4/functors/NOPTransformer.java
@@ -41,7 +41,6 @@ public class NOPTransformer<T> implements Transformer<T, T>, Serializable {
      * @return the singleton instance
      * @since 3.1
      */
-    @SuppressWarnings("unchecked")
     public static <T> Transformer<T, T> nopTransformer() {
         return INSTANCE;
     }
diff --git a/src/main/java/org/apache/commons/collections4/functors/NotNullPredicate.java b/src/main/java/org/apache/commons/collections4/functors/NotNullPredicate.java
index e6a47c4..871bbb8 100644
--- a/src/main/java/org/apache/commons/collections4/functors/NotNullPredicate.java
+++ b/src/main/java/org/apache/commons/collections4/functors/NotNullPredicate.java
@@ -41,7 +41,6 @@ public final class NotNullPredicate<T> implements Predicate<T>, Serializable {
      * @return the singleton instance
      * @since 3.1
      */
-    @SuppressWarnings("unchecked")
     public static <T> Predicate<T> notNullPredicate() {
         return INSTANCE;
     }
diff --git a/src/main/java/org/apache/commons/collections4/functors/NullPredicate.java b/src/main/java/org/apache/commons/collections4/functors/NullPredicate.java
index 5c9c43a..9230dbb 100644
--- a/src/main/java/org/apache/commons/collections4/functors/NullPredicate.java
+++ b/src/main/java/org/apache/commons/collections4/functors/NullPredicate.java
@@ -41,7 +41,6 @@ public final class NullPredicate<T> implements Predicate<T>, Serializable {
      * @return the singleton instance
      * @since 3.1
      */
-    @SuppressWarnings("unchecked")
     public static <T> Predicate<T> nullPredicate() {
         return INSTANCE;
     }
diff --git a/src/main/java/org/apache/commons/collections4/functors/TruePredicate.java b/src/main/java/org/apache/commons/collections4/functors/TruePredicate.java
index 2a899a4..f82d152 100644
--- a/src/main/java/org/apache/commons/collections4/functors/TruePredicate.java
+++ b/src/main/java/org/apache/commons/collections4/functors/TruePredicate.java
@@ -41,7 +41,6 @@ public final class TruePredicate<T> implements Predicate<T>, Serializable {
      * @return the singleton instance
      * @since 3.1
      */
-    @SuppressWarnings("unchecked")
     public static <T> Predicate<T> truePredicate() {
         return INSTANCE;
     }