[jira] [Commented] (MESOS-5994) Add Windows support for modules

["Joseph Wu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-5994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703667#comment-15703667 ] 

Joseph Wu commented on MESOS-5994:
----------------------------------

{code}
commit 58f63747f185995d7f9cbfca9d240e2d60053184
Author: Joseph Wu <jo...@mesosphere.io>
Date:   Mon Nov 28 15:37:26 2016 -0800

    Windows: Disable modules tests and related helpers.
    
    Building and linking modules has some extra challenges on Windows
    (see MESOS-5994).
    
    This patch #ifdef's some module-specific tests on Windows.
    NOTE: Most module tests are already parameterized to run the same code,
    once as a built-in class and once as a module.
    
    Review: https://reviews.apache.org/r/50827/
{code}

> Add Windows support for modules 
> --------------------------------
>
>                 Key: MESOS-5994
>                 URL: https://issues.apache.org/jira/browse/MESOS-5994
>             Project: Mesos
>          Issue Type: Improvement
>          Components: modules
>         Environment: Windows
>            Reporter: Joseph Wu
>            Priority: Minor
>              Labels: agent, master, mesos, mesosphere, windows
>
> Modules are currently not supported on Windows due to a couple limitations:
> * GCC and Clang export all symbols to shared libraries by default.  MSVC has the opposite behavior and does not export any symbols by default.  To properly create a shared library on Windows, one must {{__declspec(dllexport)}} every single exposed function/class.
> * CMake 3.4+ has utilities for auto-generating exports, but upgrading the CMake requirement has other version incompatibilities.
> * We can't load a statically linked module due to a runtime check in the protobuf library.
> For now, module-related code is not compiled on Windows.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)