[GitHub] [geode] dschneider-pivotal opened pull request #3091: GEODE-6290: change PdxInstance.equals for empty class name

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

PdxInstance.equals will only act as if an instance has a field
with the default value if the class name is not empty.
If the class name is empty it will now require that both instances
have all the same identity fields.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3091 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal closed pull request #3091: GEODE-6290: change PdxInstance.equals for empty class name

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

[ pull request closed by dschneider-pivotal ]

[ Full content available at: https://github.com/apache/geode/pull/3091 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #3091: GEODE-6290: change PdxInstance.equals for empty class name

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

If you create a factory with "" as the class name, now that factory will automatically have neverDeserialize called in it. Also added the requested unit test.

[ Full content available at: https://github.com/apache/geode/pull/3091 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-eshu commented on pull request #3091: GEODE-6290: change PdxInstance.equals for empty class name

["pivotal-eshu (GitHub)" <gi...@apache.org>]

I think it will be better to add a unit test to show that if a pdxInstance with empty class name will be equal to another pdxInstance with empty class name and has same identical fields.

Also if a user creates a pdxInstance with empty class name, will the pdxInstance have to invoke neverDeserialize method? Will it behave differently with and without invoking neverDeserialize method?

[ Full content available at: https://github.com/apache/geode/pull/3091 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #3091: GEODE-6290: change PdxInstance.equals for empty class name

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

javadocs have been improved

[ Full content available at: https://github.com/apache/geode/pull/3091 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org