You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2012/05/29 17:12:23 UTC

[jira] [Updated] (LUCENE-3590) minimize bytesref to be a ref to a byte[]

     [ https://issues.apache.org/jira/browse/LUCENE-3590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3590:
--------------------------------

    Attachment: LUCENE-3590.patch

Here's a patch with tests to improve most of the remaining issues:
* bugs in copy/append when offset !=0 (AIOOBE)
* off-by-one in charsequence.subsequence, this just happened to be previously untested.
* obey charsequence api completely (including exceptions stated in the spec)
* assert offset == 0 in grow(), as it doesnt make sense otherwise.

I'd like to backport these bugfixes to 3.6.1 as well.
                
> minimize bytesref to be a ref to a byte[]
> -----------------------------------------
>
>                 Key: LUCENE-3590
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3590
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>            Priority: Blocker
>         Attachments: LUCENE-3590.patch, LUCENE-3590_copyCtor.patch, LUCENE-3590_deprecate_comparators.patch, LUCENE-3590_equals_init.patch, LUCENE-3590_equals_init.patch, LUCENE-3590_offsets.patch, LUCENE-3590_with_clone.patch
>
>
> Setting this as blocker for 4.0, as this class is used in every API there.
> Currently this API is a little of a everything, sometimes its like a stringbuffer, it
> does numeric conversions, all kinds of stuff.
> We need this to be a ref to a byte[], nothing else. This other stuff can go somewhere else.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org