You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "yunchipang (via GitHub)" <gi...@apache.org> on 2025/06/13 17:40:26 UTC
[PR] Transition of `update` airflowctl config command [airflow]
yunchipang opened a new pull request, #51704:
URL: https://github.com/apache/airflow/pull/51704
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
partially closes: #45664 (3/3)
parent issue: #45661
implements airflowctl's `update` config command.
note: will rebase after #50556 is merged for a cleaner history!
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Transition of `update` airflowctl config command [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #51704:
URL: https://github.com/apache/airflow/pull/51704#discussion_r2145685132
##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -351,6 +351,16 @@ def list(self) -> Config | ServerResponseError:
except ServerResponseError as e:
raise e
+ def put(self, section: str, option: str, value: str) -> Config | ServerResponseError:
+ """Update a config value on the API server."""
+ try:
+ self.response = self.client.put(
+ f"/config/section/{section}/option/{option}", json={"value": value}
Review Comment:
This endpoint doesn't exist, nor should it.
https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html#tag/Config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Transition of `update` airflowctl config command [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #51704:
URL: https://github.com/apache/airflow/pull/51704#discussion_r2154951388
##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -351,6 +351,16 @@ def list(self) -> Config | ServerResponseError:
except ServerResponseError as e:
raise e
+ def put(self, section: str, option: str, value: str) -> Config | ServerResponseError:
+ """Update a config value on the API server."""
+ try:
+ self.response = self.client.put(
+ f"/config/section/{section}/option/{option}", json={"value": value}
Review Comment:
Indeed, sorry for the confusion! Thanks for the PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Transition of `update` airflowctl config command [airflow]
Posted by "yunchipang (via GitHub)" <gi...@apache.org>.
yunchipang commented on code in PR #51704:
URL: https://github.com/apache/airflow/pull/51704#discussion_r2146323702
##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -351,6 +351,16 @@ def list(self) -> Config | ServerResponseError:
except ServerResponseError as e:
raise e
+ def put(self, section: str, option: str, value: str) -> Config | ServerResponseError:
+ """Update a config value on the API server."""
+ try:
+ self.response = self.client.put(
+ f"/config/section/{section}/option/{option}", json={"value": value}
Review Comment:
ah gotcha. so `update` will just not be a command option in `airflowctl`, correct? then this PR can be closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Transition of `update` airflowctl config command [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #51704:
URL: https://github.com/apache/airflow/pull/51704#discussion_r2150867772
##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -351,6 +351,16 @@ def list(self) -> Config | ServerResponseError:
except ServerResponseError as e:
raise e
+ def put(self, section: str, option: str, value: str) -> Config | ServerResponseError:
+ """Update a config value on the API server."""
+ try:
+ self.response = self.client.put(
+ f"/config/section/{section}/option/{option}", json={"value": value}
Review Comment:
Thanks for the PR @yunchipang. Sorry for the confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Transition of `update` airflowctl config command [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham closed pull request #51704: Transition of `update` airflowctl config command
URL: https://github.com/apache/airflow/pull/51704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Transition of `update` airflowctl config command [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #51704:
URL: https://github.com/apache/airflow/pull/51704#discussion_r2146784923
##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -351,6 +351,16 @@ def list(self) -> Config | ServerResponseError:
except ServerResponseError as e:
raise e
+ def put(self, section: str, option: str, value: str) -> Config | ServerResponseError:
+ """Update a config value on the API server."""
+ try:
+ self.response = self.client.put(
+ f"/config/section/{section}/option/{option}", json={"value": value}
Review Comment:
Yes, there is no update endpoint in the API. The only way is to use a direct database connection, which we won't do in `airflowctl`. Thanks Jed!
We can close the PR. After `lint`, which can run with the current API support, is merged, we can assume `config` transition is done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org