You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/25 06:52:09 UTC
[GitHub] [spark] LuciferYang commented on a diff in pull request #37654: [WIP][SPARK-40216][SQL] Extract common `ParquetUtils.prepareWrite` method ` to deduplicate code in `ParquetFileFormat` and `ParquetWrite`
LuciferYang commented on code in PR #37654:
URL: https://github.com/apache/spark/pull/37654#discussion_r954566232
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala:
##########
@@ -72,87 +69,9 @@ class ParquetFileFormat
job: Job,
options: Map[String, String],
dataSchema: StructType): OutputWriterFactory = {
- val parquetOptions = new ParquetOptions(options, sparkSession.sessionState.conf)
-
- val conf = ContextUtil.getConfiguration(job)
-
- val committerClass =
- conf.getClass(
- SQLConf.PARQUET_OUTPUT_COMMITTER_CLASS.key,
- classOf[ParquetOutputCommitter],
- classOf[OutputCommitter])
-
- if (conf.get(SQLConf.PARQUET_OUTPUT_COMMITTER_CLASS.key) == null) {
- logInfo("Using default output committer for Parquet: " +
- classOf[ParquetOutputCommitter].getCanonicalName)
- } else {
- logInfo("Using user defined output committer for Parquet: " + committerClass.getCanonicalName)
- }
-
- conf.setClass(
- SQLConf.OUTPUT_COMMITTER_CLASS.key,
- committerClass,
- classOf[OutputCommitter])
-
- // We're not really using `ParquetOutputFormat[Row]` for writing data here, because we override
- // it in `ParquetOutputWriter` to support appending and dynamic partitioning. The reason why
- // we set it here is to setup the output committer class to `ParquetOutputCommitter`, which is
- // bundled with `ParquetOutputFormat[Row]`.
- job.setOutputFormatClass(classOf[ParquetOutputFormat[Row]])
-
- ParquetOutputFormat.setWriteSupportClass(job, classOf[ParquetWriteSupport])
-
- // This metadata is useful for keeping UDTs like Vector/Matrix.
- ParquetWriteSupport.setSchema(dataSchema, conf)
-
- // Sets flags for `ParquetWriteSupport`, which converts Catalyst schema to Parquet
- // schema and writes actual rows to Parquet files.
- conf.set(
- SQLConf.PARQUET_WRITE_LEGACY_FORMAT.key,
- sparkSession.sessionState.conf.writeLegacyParquetFormat.toString)
-
- conf.set(
- SQLConf.PARQUET_OUTPUT_TIMESTAMP_TYPE.key,
- sparkSession.sessionState.conf.parquetOutputTimestampType.toString)
-
- conf.set(
- SQLConf.PARQUET_FIELD_ID_WRITE_ENABLED.key,
- sparkSession.sessionState.conf.parquetFieldIdWriteEnabled.toString)
-
- conf.set(
- SQLConf.PARQUET_TIMESTAMP_NTZ_ENABLED.key,
Review Comment:
This is the first difference:
`SQLConf.PARQUET_TIMESTAMP_NTZ_ENABLED.key` exists only in `ParquetFileFormat.prepareWrite`but not in `ParquetWrite.prepareWrite`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org