You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Wouter de Vaal (JIRA)" <ji...@apache.org> on 2010/06/01 14:55:37 UTC

[jira] Created: (WICKET-2904) variations don't work when using wicket:link with images

variations don't work when using wicket:link with images
--------------------------------------------------------

                 Key: WICKET-2904
                 URL: https://issues.apache.org/jira/browse/WICKET-2904
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.4.9
            Reporter: Wouter de Vaal


I'm trying to use variations with images that are automatically
localized when they are within wicket:link. When I turned on debugging
I could see that it tries to get the image for the current locale, or
one without locale extension when it is not available (logo_nl.png
versus logo.png). However when I change getVariation() on the page,
nothing notable happened in the debug statements.

So I started debugging and I found out that Component.getStyle is
actually called, but will never give a result, as the parent is
consulted to get the variation, however the automatically added
components of type AutoLinkResolver$ResourceReferenceAutolink do not
get a parent when they are created.
Could this be a bug? I would expect the variation to be used when I
autolink an image within a normal page.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-2904) variations don't work when using wicket:link with images

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-2904.
-----------------------------------

         Assignee: Igor Vaynberg
    Fix Version/s: 1.4.10
                   1.5-M1
       Resolution: Fixed

> variations don't work when using wicket:link with images
> --------------------------------------------------------
>
>                 Key: WICKET-2904
>                 URL: https://issues.apache.org/jira/browse/WICKET-2904
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Wouter de Vaal
>            Assignee: Igor Vaynberg
>             Fix For: 1.4.10, 1.5-M1
>
>         Attachments: variationbug.tar.gz, WICKET-2904.patch
>
>
> I'm trying to use variations with images that are automatically
> localized when they are within wicket:link. When I turned on debugging
> I could see that it tries to get the image for the current locale, or
> one without locale extension when it is not available (logo_nl.png
> versus logo.png). However when I change getVariation() on the page,
> nothing notable happened in the debug statements.
> So I started debugging and I found out that Component.getStyle is
> actually called, but will never give a result, as the parent is
> consulted to get the variation, however the automatically added
> components of type AutoLinkResolver$ResourceReferenceAutolink do not
> get a parent when they are created.
> Could this be a bug? I would expect the variation to be used when I
> autolink an image within a normal page.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2904) variations don't work when using wicket:link with images

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov updated WICKET-2904:
------------------------------------

    Attachment: WICKET-2904.patch

Attaching a patch that allows <wicket:link> auto-components to resolve their parent's variation.

@Juergen: Please review the code.

@Wouter; I am waiting for my beer in any pub in Amsterdam ;-) 

> variations don't work when using wicket:link with images
> --------------------------------------------------------
>
>                 Key: WICKET-2904
>                 URL: https://issues.apache.org/jira/browse/WICKET-2904
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Wouter de Vaal
>         Attachments: variationbug.tar.gz, WICKET-2904.patch
>
>
> I'm trying to use variations with images that are automatically
> localized when they are within wicket:link. When I turned on debugging
> I could see that it tries to get the image for the current locale, or
> one without locale extension when it is not available (logo_nl.png
> versus logo.png). However when I change getVariation() on the page,
> nothing notable happened in the debug statements.
> So I started debugging and I found out that Component.getStyle is
> actually called, but will never give a result, as the parent is
> consulted to get the variation, however the automatically added
> components of type AutoLinkResolver$ResourceReferenceAutolink do not
> get a parent when they are created.
> Could this be a bug? I would expect the variation to be used when I
> autolink an image within a normal page.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-2904) variations don't work when using wicket:link with images

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880925#action_12880925 ] 

Hudson commented on WICKET-2904:
--------------------------------

Integrated in Apache Wicket 1.4.x #9 (See [http://hudson.zones.apache.org/hudson/job/Apache%20Wicket%201.4.x/9/])
    WICKET-2904 variations don't work when using wicket:link with images
Issue: WICKET-2904


> variations don't work when using wicket:link with images
> --------------------------------------------------------
>
>                 Key: WICKET-2904
>                 URL: https://issues.apache.org/jira/browse/WICKET-2904
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Wouter de Vaal
>            Assignee: Igor Vaynberg
>             Fix For: 1.4.10, 1.5-M1
>
>         Attachments: variationbug.tar.gz, WICKET-2904.patch
>
>
> I'm trying to use variations with images that are automatically
> localized when they are within wicket:link. When I turned on debugging
> I could see that it tries to get the image for the current locale, or
> one without locale extension when it is not available (logo_nl.png
> versus logo.png). However when I change getVariation() on the page,
> nothing notable happened in the debug statements.
> So I started debugging and I found out that Component.getStyle is
> actually called, but will never give a result, as the parent is
> consulted to get the variation, however the automatically added
> components of type AutoLinkResolver$ResourceReferenceAutolink do not
> get a parent when they are created.
> Could this be a bug? I would expect the variation to be used when I
> autolink an image within a normal page.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2904) variations don't work when using wicket:link with images

Posted by "Wouter de Vaal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wouter de Vaal updated WICKET-2904:
-----------------------------------

    Attachment: variationbug.tar.gz

Here you go. 
The homepage shows two images, both of which I expected to be the variantion "wide", but onthe the component images shows correctly, the one within wicket:link does not.

> variations don't work when using wicket:link with images
> --------------------------------------------------------
>
>                 Key: WICKET-2904
>                 URL: https://issues.apache.org/jira/browse/WICKET-2904
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Wouter de Vaal
>         Attachments: variationbug.tar.gz
>
>
> I'm trying to use variations with images that are automatically
> localized when they are within wicket:link. When I turned on debugging
> I could see that it tries to get the image for the current locale, or
> one without locale extension when it is not available (logo_nl.png
> versus logo.png). However when I change getVariation() on the page,
> nothing notable happened in the debug statements.
> So I started debugging and I found out that Component.getStyle is
> actually called, but will never give a result, as the parent is
> consulted to get the variation, however the automatically added
> components of type AutoLinkResolver$ResourceReferenceAutolink do not
> get a parent when they are created.
> Could this be a bug? I would expect the variation to be used when I
> autolink an image within a normal page.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-2904) variations don't work when using wicket:link with images

Posted by "Wouter de Vaal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878858#action_12878858 ] 

Wouter de Vaal commented on WICKET-2904:
----------------------------------------

Martin,

This works perfectly, thanks! I live in the south of The Netherlands, so perhaps a beer in Eindhoven ;-)

> variations don't work when using wicket:link with images
> --------------------------------------------------------
>
>                 Key: WICKET-2904
>                 URL: https://issues.apache.org/jira/browse/WICKET-2904
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Wouter de Vaal
>         Attachments: variationbug.tar.gz, WICKET-2904.patch
>
>
> I'm trying to use variations with images that are automatically
> localized when they are within wicket:link. When I turned on debugging
> I could see that it tries to get the image for the current locale, or
> one without locale extension when it is not available (logo_nl.png
> versus logo.png). However when I change getVariation() on the page,
> nothing notable happened in the debug statements.
> So I started debugging and I found out that Component.getStyle is
> actually called, but will never give a result, as the parent is
> consulted to get the variation, however the automatically added
> components of type AutoLinkResolver$ResourceReferenceAutolink do not
> get a parent when they are created.
> Could this be a bug? I would expect the variation to be used when I
> autolink an image within a normal page.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-2904) variations don't work when using wicket:link with images

Posted by "Wouter de Vaal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880930#action_12880930 ] 

Wouter de Vaal commented on WICKET-2904:
----------------------------------------

*cheer*

Thanks gentlemen!

> variations don't work when using wicket:link with images
> --------------------------------------------------------
>
>                 Key: WICKET-2904
>                 URL: https://issues.apache.org/jira/browse/WICKET-2904
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Wouter de Vaal
>            Assignee: Igor Vaynberg
>             Fix For: 1.4.10, 1.5-M1
>
>         Attachments: variationbug.tar.gz, WICKET-2904.patch
>
>
> I'm trying to use variations with images that are automatically
> localized when they are within wicket:link. When I turned on debugging
> I could see that it tries to get the image for the current locale, or
> one without locale extension when it is not available (logo_nl.png
> versus logo.png). However when I change getVariation() on the page,
> nothing notable happened in the debug statements.
> So I started debugging and I found out that Component.getStyle is
> actually called, but will never give a result, as the parent is
> consulted to get the variation, however the automatically added
> components of type AutoLinkResolver$ResourceReferenceAutolink do not
> get a parent when they are created.
> Could this be a bug? I would expect the variation to be used when I
> autolink an image within a normal page.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-2904) variations don't work when using wicket:link with images

Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873986#action_12873986 ] 

Jeremy Thomerson commented on WICKET-2904:
------------------------------------------

please create a quickstart and attach it to this report




-- 
Jeremy Thomerson
http://www.wickettraining.com


> variations don't work when using wicket:link with images
> --------------------------------------------------------
>
>                 Key: WICKET-2904
>                 URL: https://issues.apache.org/jira/browse/WICKET-2904
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.9
>            Reporter: Wouter de Vaal
>
> I'm trying to use variations with images that are automatically
> localized when they are within wicket:link. When I turned on debugging
> I could see that it tries to get the image for the current locale, or
> one without locale extension when it is not available (logo_nl.png
> versus logo.png). However when I change getVariation() on the page,
> nothing notable happened in the debug statements.
> So I started debugging and I found out that Component.getStyle is
> actually called, but will never give a result, as the parent is
> consulted to get the variation, however the automatically added
> components of type AutoLinkResolver$ResourceReferenceAutolink do not
> get a parent when they are created.
> Could this be a bug? I would expect the variation to be used when I
> autolink an image within a normal page.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.