You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "palashc (via GitHub)" <gi...@apache.org> on 2024/01/02 22:07:15 UTC
[PR] PHOENIX-7166 : Set default values of feature flags introduced by metadata caching redesign [phoenix]
palashc opened a new pull request, #1778:
URL: https://github.com/apache/phoenix/pull/1778
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7166 : Set default values of feature flags introduced by metadata caching redesign [phoenix]
Posted by "tkhurana (via GitHub)" <gi...@apache.org>.
tkhurana commented on code in PR #1778:
URL: https://github.com/apache/phoenix/pull/1778#discussion_r1486954585
##########
phoenix-core-client/src/main/java/org/apache/phoenix/util/ViewUtil.java:
##########
@@ -484,7 +484,8 @@ public static void addIndexesFromParent(PhoenixConnection connection, PTable vie
.setTableName(modifiedIndexName)
.setViewStatement(viewStatement)
.setUpdateCacheFrequency(view.getUpdateCacheFrequency())
- .setTenantId(view.getTenantId())
+ //retain the tenantId from the index being inherited
Review Comment:
@palashc Can you add a testcase in whereoptimizer test with a global view and global view index and a query on tenant view uses index and the scan start row has the tenantid bytes similar to this https://github.com/apache/phoenix/blob/master/phoenix-core/src/test/java/org/apache/phoenix/compile/WhereOptimizerTest.java#L2670-L2671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7166 : Set default values of feature flags introduced by metadata caching redesign [phoenix]
Posted by "tkhurana (via GitHub)" <gi...@apache.org>.
tkhurana commented on code in PR #1778:
URL: https://github.com/apache/phoenix/pull/1778#discussion_r1487053222
##########
phoenix-core-client/src/main/java/org/apache/phoenix/util/ViewUtil.java:
##########
@@ -484,7 +484,8 @@ public static void addIndexesFromParent(PhoenixConnection connection, PTable vie
.setTableName(modifiedIndexName)
.setViewStatement(viewStatement)
.setUpdateCacheFrequency(view.getUpdateCacheFrequency())
- .setTenantId(view.getTenantId())
+ //retain the tenantId from the index being inherited
Review Comment:
Looks good @palashc thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7166 : Set default values of feature flags introduced by metadata caching redesign [phoenix]
Posted by "palashc (via GitHub)" <gi...@apache.org>.
palashc closed pull request #1778: PHOENIX-7166 : Set default values of feature flags introduced by metadata caching redesign
URL: https://github.com/apache/phoenix/pull/1778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7166 : Set default values of feature flags introduced by metadata caching redesign [phoenix]
Posted by "palashc (via GitHub)" <gi...@apache.org>.
palashc commented on code in PR #1778:
URL: https://github.com/apache/phoenix/pull/1778#discussion_r1487022527
##########
phoenix-core-client/src/main/java/org/apache/phoenix/util/ViewUtil.java:
##########
@@ -484,7 +484,8 @@ public static void addIndexesFromParent(PhoenixConnection connection, PTable vie
.setTableName(modifiedIndexName)
.setViewStatement(viewStatement)
.setUpdateCacheFrequency(view.getUpdateCacheFrequency())
- .setTenantId(view.getTenantId())
+ //retain the tenantId from the index being inherited
Review Comment:
@tkhurana Let me know if the test looks fine - https://github.com/apache/phoenix/pull/1778/commits/d83146b0e66b842774cc024e48aaea290c286cd9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org