You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/09/27 12:22:32 UTC
[GitHub] [cloudstack] JoaoJandre opened a new pull request, #6769: Show name instead of description in the infocards and breadcrumbs
JoaoJandre opened a new pull request, #6769:
URL: https://github.com/apache/cloudstack/pull/6769
### Description
Currently on the infocards and breadcrumbs the object description is shown instead of the name. This PR updates de UI to use the name when possible, since the descriptions can be long to properly describe the object, and the name is shorter and intended to identify the object.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
Before:
After:
### How Has This Been Tested?
This was tested in a local lab, by browsing the UI and checking if the names would appear in the breadcrumbs and infocards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6769: Show name instead of description in the infocards and breadcrumbs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6769:
URL: https://github.com/apache/cloudstack/pull/6769#issuecomment-1261932442
> Historically the purpose of the displaytext has been the name you want to show in the UI for a resource; this is why the code shows displaytext before the name. (for ex. name of an offering could be an internal thing and description or displaytext is what you want to show the users)
but there is a `displayname` and a `displaytext`.
`displaytext` is more like `description` which is a bit overdone for a breadcrum, i think. `displayname` is still the first choice if available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6769: Show name instead of description in the infocards and breadcrumbs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6769:
URL: https://github.com/apache/cloudstack/pull/6769#issuecomment-1261990783
equally fair. Do you think this change make it as much worse for service offerings as it makes it better for disk offerings?
I am inclined to merge this, unless...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6769: Show name instead of description in the infocards and breadcrumbs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6769:
URL: https://github.com/apache/cloudstack/pull/6769#issuecomment-1259430926
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6769: Show name instead of description in the infocards and breadcrumbs
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6769:
URL: https://github.com/apache/cloudstack/pull/6769#issuecomment-1259429362
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6769: Show name instead of description in the infocards and breadcrumbs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6769:
URL: https://github.com/apache/cloudstack/pull/6769#issuecomment-1259437285
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6769 (SL-JID-2425)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6769: Show name instead of description in the infocards and breadcrumbs
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6769:
URL: https://github.com/apache/cloudstack/pull/6769#issuecomment-1259488558
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6769?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6769](https://codecov.io/gh/apache/cloudstack/pull/6769?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (82df52b) into [main](https://codecov.io/gh/apache/cloudstack/commit/8ab8fdc1db4fed4d906c69618980fda9ef710e6a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ab8fdc) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #6769 +/- ##
============================================
- Coverage 10.53% 10.53% -0.01%
Complexity 6786 6786
============================================
Files 2464 2464
Lines 243988 243988
Branches 38185 38185
============================================
- Hits 25699 25694 -5
- Misses 215054 215061 +7
+ Partials 3235 3233 -2
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6769?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/6769/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `28.84% <0.00%> (-15.39%)` | :arrow_down: |
| [...cloudstack/network/contrail/model/ModelObject.java](https://codecov.io/gh/apache/cloudstack/pull/6769/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdC5qYXZh) | `29.16% <0.00%> (-4.17%)` | :arrow_down: |
| [...apache/cloudstack/syslog/AlertsSyslogAppender.java](https://codecov.io/gh/apache/cloudstack/pull/6769/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zeXNsb2ctYWxlcnRzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N5c2xvZy9BbGVydHNTeXNsb2dBcHBlbmRlci5qYXZh) | `58.75% <0.00%> (+2.25%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6769: Show name instead of description in the infocards and breadcrumbs
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6769:
URL: https://github.com/apache/cloudstack/pull/6769#issuecomment-1261945686
@DaanHoogland fair point, it's really inconsistent (for some resources such as VM this is display name and others it is display text such as service offerings)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #6769: Show name instead of description in the infocards and breadcrumbs
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #6769:
URL: https://github.com/apache/cloudstack/pull/6769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6769: Show name instead of description in the infocards and breadcrumbs
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6769:
URL: https://github.com/apache/cloudstack/pull/6769#issuecomment-1262042795
I think we can merge this, but something like this won't fully satisfy everyone in the community (esp. users who are used to using the old UI and how/which name is used for showing resource in the table/list-view and other places).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6769: Show name instead of description in the infocards and breadcrumbs
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6769:
URL: https://github.com/apache/cloudstack/pull/6769#issuecomment-1261919592
Historically the purpose of the displaytext has been the name you want to show in the UI for a resource; this is why the code shows displaytext before the name. (for ex. name of an offering could be an internal thing and description or displaytext is what you want to show the users)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org